From be5b2cc061e0225d04c8ac38c349d71ed59b54bb Mon Sep 17 00:00:00 2001 From: Pablo Gamito Date: Tue, 26 Oct 2021 12:45:28 +0200 Subject: [PATCH] Remove unnecessary surface updates Test: atest FlickerTests:TaskTransitionTest + make sure the background color still shows as expected Bug: 204409129 Change-Id: I80118e6e3d62b7e842d3d036eb86b5c88ff0f04f --- .../core/java/com/android/server/wm/TaskDisplayArea.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/services/core/java/com/android/server/wm/TaskDisplayArea.java b/services/core/java/com/android/server/wm/TaskDisplayArea.java index 901f14f346055..d4035b5b098b9 100644 --- a/services/core/java/com/android/server/wm/TaskDisplayArea.java +++ b/services/core/java/com/android/server/wm/TaskDisplayArea.java @@ -42,8 +42,6 @@ import static com.android.server.wm.TaskFragment.TASK_FRAGMENT_VISIBILITY_VISIBL import static com.android.server.wm.WindowManagerDebugConfig.DEBUG_ROOT_TASK; import static com.android.server.wm.WindowManagerDebugConfig.TAG_WM; -import static java.lang.Integer.MIN_VALUE; - import android.annotation.ColorInt; import android.annotation.Nullable; import android.app.ActivityOptions; @@ -907,15 +905,11 @@ final class TaskDisplayArea extends DisplayArea { float r = ((color >> 16) & 0xff) / 255.0f; float g = ((color >> 8) & 0xff) / 255.0f; float b = ((color >> 0) & 0xff) / 255.0f; - float a = ((color >> 24) & 0xff) / 255.0f; mColorLayerCounter++; - getPendingTransaction().setLayer(mColorBackgroundLayer, MIN_VALUE) + getPendingTransaction() .setColor(mColorBackgroundLayer, new float[]{r, g, b}) - .setAlpha(mColorBackgroundLayer, a) - .setWindowCrop(mColorBackgroundLayer, getSurfaceWidth(), getSurfaceHeight()) - .setPosition(mColorBackgroundLayer, 0, 0) .show(mColorBackgroundLayer); scheduleAnimation();