From 2ba38a72178ddaceacbd109c0661a12e84177aa1 Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Tue, 18 Jul 2023 12:08:57 -0400 Subject: [PATCH] Tapping a notification closes inline reply, regardless of whether the user has typed anything. Test: tap reply; tap notification; observe notification content intent does not launch Fixes: 289087107 Change-Id: I7010e07c4d17ffc78a1ba1aa8b5159e94d213be9 --- .../statusbar/phone/StatusBarNotificationActivityStarter.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java index ec0c00e26c2fe..8de213f262c2d 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java @@ -215,8 +215,7 @@ class StatusBarNotificationActivityStarter implements NotificationActivityStarte public void onNotificationClicked(NotificationEntry entry, ExpandableNotificationRow row) { mLogger.logStartingActivityFromClick(entry); - if (mRemoteInputManager.isRemoteInputActive(entry) - && !TextUtils.isEmpty(row.getActiveRemoteInputText())) { + if (mRemoteInputManager.isRemoteInputActive(entry)) { // We have an active remote input typed and the user clicked on the notification. // this was probably unintentional, so we're closing the edit text instead. mRemoteInputManager.closeRemoteInputs();