Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep close_idle_connections optimization for all devices

Browse Source 
Internal compatibility testing didn't reveal any issues related to it.

Rationale to not make it specific to low-ram:
1) Consistent behavior from app perspective. close_idle_connections
   is a behavioural change and may affect apps relying on undocumented
   behavior of connection pooling. Developers can detect problems
   without testing on low-ram device
2) Closing idle connections is especially important in WAL mode.
   Disabling this feature would become an issue if more apps are
   switching to WAL and we would need to re-enable this optimization.

Test: n/a
Bug: 63398887
Change-Id: I1b431f44daa2d337aad7f12f8e1409ae3143ded0
This commit is contained in:
Fyodor Kupolov
2017-08-23 16:36:15 -07:00
parent f394ac4eba
commit 2c7e249b84
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/database/sqlite/SQLiteDatabase.java
View File

@@ -79,8 +79,6 @@ public final class SQLiteDatabase extends SQLiteClosable {
private static final int EVENT_DB_CORRUPT = 75004;
// TODO b/63398887 STOPSHIP.
// Temporarily enabled for testing across a broader set of dogfood devices.
private static final boolean DEBUG_CLOSE_IDLE_CONNECTIONS = SystemProperties
.getBoolean("persist.debug.sqlite.close_idle_connections", true);