Merge "Remove unused global references in JNI code supporting HwBinder."
This commit is contained in:
@@ -83,12 +83,6 @@ JHwBlob::JHwBlob(JNIEnv *env, jobject thiz, size_t size)
|
||||
mSize(size),
|
||||
mOwnsBuffer(true),
|
||||
mHandle(0) {
|
||||
jclass clazz = env->GetObjectClass(thiz);
|
||||
CHECK(clazz != NULL);
|
||||
|
||||
mClass = (jclass)env->NewGlobalRef(clazz);
|
||||
mObject = env->NewWeakGlobalRef(thiz);
|
||||
|
||||
if (size > 0) {
|
||||
mBuffer = malloc(size);
|
||||
}
|
||||
@@ -99,14 +93,6 @@ JHwBlob::~JHwBlob() {
|
||||
free(mBuffer);
|
||||
mBuffer = nullptr;
|
||||
}
|
||||
|
||||
JNIEnv *env = AndroidRuntime::getJNIEnv();
|
||||
|
||||
env->DeleteWeakGlobalRef(mObject);
|
||||
mObject = NULL;
|
||||
|
||||
env->DeleteGlobalRef(mClass);
|
||||
mClass = NULL;
|
||||
}
|
||||
|
||||
void JHwBlob::setTo(const void *ptr, size_t handle) {
|
||||
|
||||
@@ -70,9 +70,6 @@ private:
|
||||
sp<JHwBlob> mBlob;
|
||||
};
|
||||
|
||||
jclass mClass;
|
||||
jobject mObject;
|
||||
|
||||
void *mBuffer;
|
||||
size_t mSize;
|
||||
bool mOwnsBuffer;
|
||||
|
||||
@@ -166,10 +166,6 @@ JHwParcel::JHwParcel(JNIEnv *env, jobject thiz)
|
||||
mOwnsParcel(false),
|
||||
mTransactCallback(nullptr),
|
||||
mWasSent(false) {
|
||||
jclass clazz = env->GetObjectClass(thiz);
|
||||
CHECK(clazz != NULL);
|
||||
|
||||
mObject = env->NewWeakGlobalRef(thiz);
|
||||
}
|
||||
|
||||
JHwParcel::~JHwParcel() {
|
||||
@@ -178,9 +174,6 @@ JHwParcel::~JHwParcel() {
|
||||
mStorage.release(env);
|
||||
|
||||
setParcel(NULL, false /* assumeOwnership */);
|
||||
|
||||
env->DeleteWeakGlobalRef(mObject);
|
||||
mObject = NULL;
|
||||
}
|
||||
|
||||
hardware::Parcel *JHwParcel::getParcel() {
|
||||
|
||||
@@ -53,8 +53,6 @@ protected:
|
||||
virtual ~JHwParcel();
|
||||
|
||||
private:
|
||||
jobject mObject;
|
||||
|
||||
hardware::Parcel *mParcel;
|
||||
bool mOwnsParcel;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user