From ce4957eb37bda0ab6976d0835fe6851232ddf5a3 Mon Sep 17 00:00:00 2001 From: Wei Jia Date: Thu, 16 Jun 2016 15:18:20 -0700 Subject: [PATCH] MediaPlayer: fix java doc for setPlaybackParams. Bug: 29032949 Change-Id: I75a59e2a4c75b5e84e2257f8e386d7b05faf9c1b --- media/java/android/media/MediaPlayer.java | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/media/java/android/media/MediaPlayer.java b/media/java/android/media/MediaPlayer.java index 4d40e6ba99abe..8d4a1510715a2 100644 --- a/media/java/android/media/MediaPlayer.java +++ b/media/java/android/media/MediaPlayer.java @@ -476,10 +476,10 @@ import java.lang.ref.WeakReference; * This method can be called in any state and calling it does not change * the object state.

* setPlaybackParams

- * any

- * {}

- * This method can be called in any state and calling it does not change - * the object state.

+ * {Initialized, Prepared, Started, Paused, PlaybackCompleted, Error}

+ * {Idle, Stopped}

+ * This method will change state in some cases, depending on when it's called. + *

* setScreenOnWhilePlaying * any

* {}

@@ -1449,12 +1449,18 @@ public class MediaPlayer extends PlayerBase } /** - * Sets playback rate using {@link PlaybackParams}. + * Sets playback rate using {@link PlaybackParams}. The object sets its internal + * PlaybackParams to the input, except that the object remembers previous speed + * when input speed is zero. This allows the object to resume at previous speed + * when start() is called. Calling it before the object is prepared does not change + * the object state. After the object is prepared, calling it with zero speed is + * equivalent to calling pause(). After the object is prepared, calling it with + * non-zero speed is equivalent to calling start(). * * @param params the playback params. * * @throws IllegalStateException if the internal player engine has not been - * initialized. + * initialized or has been released. * @throws IllegalArgumentException if params is not supported. */ public native void setPlaybackParams(@NonNull PlaybackParams params);