Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Revoke the uri permission when the file is deleted" into pi-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-12-03 04:55:15 +00:00
committed by Android (Google) Code Review
parent 6f14b9586d c5c373c258
commit 2b52397d56
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/java/com/android/internal/content/FileSystemProvider.java
View File

@@ -93,6 +93,14 @@ public abstract class FileSystemProvider extends DocumentsProvider {
// Default is no-op // Default is no-op
} }
/**
* Callback indicating that the given document has been deleted or moved. This gives
* the provider a hook to revoke the uri permissions.
*/
protected void onDocIdDeleted(String docId) {
// Default is no-op
}
@Override @Override
public boolean onCreate() { public boolean onCreate() {
throw new UnsupportedOperationException( throw new UnsupportedOperationException(
@@ -243,6 +251,7 @@ public abstract class FileSystemProvider extends DocumentsProvider {
final String afterDocId = getDocIdForFile(after); final String afterDocId = getDocIdForFile(after);
onDocIdChanged(docId); onDocIdChanged(docId);
onDocIdDeleted(docId);
onDocIdChanged(afterDocId); onDocIdChanged(afterDocId);
final File beforeVisibleFile = getFileForDocId(docId, true); final File beforeVisibleFile = getFileForDocId(docId, true);
@@ -274,6 +283,7 @@ public abstract class FileSystemProvider extends DocumentsProvider {
final String docId = getDocIdForFile(after); final String docId = getDocIdForFile(after);
onDocIdChanged(sourceDocumentId); onDocIdChanged(sourceDocumentId);
onDocIdDeleted(sourceDocumentId);
onDocIdChanged(docId); onDocIdChanged(docId);
moveInMediaStore(visibleFileBefore, getFileForDocId(docId, true)); moveInMediaStore(visibleFileBefore, getFileForDocId(docId, true));
@@ -325,6 +335,7 @@ public abstract class FileSystemProvider extends DocumentsProvider {
} }
onDocIdChanged(docId); onDocIdChanged(docId);
onDocIdDeleted(docId);
removeFromMediaStore(visibleFile, isDirectory); removeFromMediaStore(visibleFile, isDirectory);
} }

6
packages/ExternalStorageProvider/src/com/android/externalstorage/ExternalStorageProvider.java
View File

@@ -430,6 +430,12 @@ public class ExternalStorageProvider extends FileSystemProvider {
} }
} }
@Override
protected void onDocIdDeleted(String docId) {
Uri uri = DocumentsContract.buildDocumentUri(AUTHORITY, docId);
getContext().revokeUriPermission(uri, ~0);
}
@Override @Override
public Cursor queryRoots(String[] projection) throws FileNotFoundException { public Cursor queryRoots(String[] projection) throws FileNotFoundException {
final MatrixCursor result = new MatrixCursor(resolveRootProjection(projection)); final MatrixCursor result = new MatrixCursor(resolveRootProjection(projection));