From 89358feae40fda647eb1d688094b92fb7b7d1e31 Mon Sep 17 00:00:00 2001 From: Muhammad Qureshi Date: Fri, 12 Jun 2020 18:09:34 -0700 Subject: [PATCH] Fix testMultipleConditions flake Use vector instead of vector. vector is not thread-safe: https://en.cppreference.com/w/cpp/container#Thread_safety Fixes: 156690351 Test: atest --iterations=500 statsd_test:MultiConditionTrigger#TestMultipleConditions Change-Id: I9121747ffbee0864afbff993e7fe417104827952 --- cmds/statsd/tests/utils/MultiConditionTrigger_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds/statsd/tests/utils/MultiConditionTrigger_test.cpp b/cmds/statsd/tests/utils/MultiConditionTrigger_test.cpp index db402a0dd658a..32cecd3b9dbc3 100644 --- a/cmds/statsd/tests/utils/MultiConditionTrigger_test.cpp +++ b/cmds/statsd/tests/utils/MultiConditionTrigger_test.cpp @@ -50,13 +50,13 @@ TEST(MultiConditionTrigger, TestMultipleConditions) { }); vector threads; - vector done(numConditions, false); + vector done(numConditions, 0); int i = 0; for (const string& conditionName : conditionNames) { threads.emplace_back([&done, &conditionName, &trigger, i] { sleep_for(chrono::milliseconds(3)); - done[i] = true; + done[i] = 1; trigger.markComplete(conditionName); }); i++;