Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Use try-with-resource statement for dream metadata to ensure proper cleanup." into tm-dev

Browse Source
This commit is contained in:
Lucas Silva
2022-06-03 14:22:35 +00:00
committed by Android (Google) Code Review
parent 665f010aae b30b1683e1
commit 2aa3ecaf9e
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
core/java/android/service/dreams/DreamService.java
View File

@@ -1130,18 +1130,16 @@ public class DreamService extends Service implements Window.Callback {
final PackageManager pm = context.getPackageManager(); final PackageManager pm = context.getPackageManager();
final TypedArray rawMetadata = readMetadata(pm, serviceInfo); try (TypedArray rawMetadata = readMetadata(pm, serviceInfo)) {
if (rawMetadata == null) return null; if (rawMetadata == null) return null;
return new DreamMetadata(
final DreamMetadata metadata = new DreamMetadata( convertToComponentName(rawMetadata.getString(
convertToComponentName(rawMetadata.getString( com.android.internal.R.styleable.Dream_settingsActivity), serviceInfo),
com.android.internal.R.styleable.Dream_settingsActivity), serviceInfo), rawMetadata.getDrawable(
rawMetadata.getDrawable( com.android.internal.R.styleable.Dream_previewImage),
com.android.internal.R.styleable.Dream_previewImage), rawMetadata.getBoolean(R.styleable.Dream_showClockAndComplications,
rawMetadata.getBoolean(R.styleable.Dream_showClockAndComplications, DEFAULT_SHOW_COMPLICATIONS));
DEFAULT_SHOW_COMPLICATIONS)); }
rawMetadata.recycle();
return metadata;
} }
/** /**