From 29ed5a466c5e01d4e6d2e448bda64314b0b77e17 Mon Sep 17 00:00:00 2001 From: Lucas Silva Date: Mon, 14 Feb 2022 20:13:55 +0000 Subject: [PATCH] Remove dream placeholder image from settingslib. This logic is implemented within the settings UI, since the placeholder is treated differently than regular preview images. Test: locally on device Bug: 213887094 Change-Id: I556f551e2c5659f4fbe951b984dc04cf373e679c --- .../res/drawable/default_dream_preview.xml | 20 ------------------- core/res/res/values/symbols.xml | 1 - .../settingslib/dream/DreamBackend.java | 6 ------ 3 files changed, 27 deletions(-) delete mode 100644 core/res/res/drawable/default_dream_preview.xml diff --git a/core/res/res/drawable/default_dream_preview.xml b/core/res/res/drawable/default_dream_preview.xml deleted file mode 100644 index bf4a04b30f193..0000000000000 --- a/core/res/res/drawable/default_dream_preview.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 0190451ac9703..4f3033746c3f9 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -2233,7 +2233,6 @@ - diff --git a/packages/SettingsLib/src/com/android/settingslib/dream/DreamBackend.java b/packages/SettingsLib/src/com/android/settingslib/dream/DreamBackend.java index bd3deae8c01a6..fcb56d2f70169 100644 --- a/packages/SettingsLib/src/com/android/settingslib/dream/DreamBackend.java +++ b/packages/SettingsLib/src/com/android/settingslib/dream/DreamBackend.java @@ -50,7 +50,6 @@ import java.util.stream.Collectors; public class DreamBackend { private static final String TAG = "DreamBackend"; private static final boolean DEBUG = false; - private final Drawable mDreamPreviewDefault; public static class DreamInfo { public CharSequence caption; @@ -135,8 +134,6 @@ public class DreamBackend { com.android.internal.R.bool.config_dreamsActivatedOnSleepByDefault); mDreamsActivatedOnDockByDefault = resources.getBoolean( com.android.internal.R.bool.config_dreamsActivatedOnDockByDefault); - mDreamPreviewDefault = resources.getDrawable( - com.android.internal.R.drawable.default_dream_preview); mDisabledDreams = Arrays.stream(resources.getStringArray( com.android.internal.R.array.config_disabledDreamComponents)) .map(ComponentName::unflattenFromString) @@ -182,9 +179,6 @@ public class DreamBackend { dreamInfo.settingsComponentName = dreamMetadata.settingsActivity; dreamInfo.previewImage = dreamMetadata.previewImage; } - if (dreamInfo.previewImage == null) { - dreamInfo.previewImage = mDreamPreviewDefault; - } dreamInfos.add(dreamInfo); } dreamInfos.sort(mComparator);