From 138bebf4c18d0b573732aac6faa4573a57c295f5 Mon Sep 17 00:00:00 2001 From: Michael Wachenschwanz Date: Thu, 18 May 2017 22:09:18 +0000 Subject: [PATCH] DO NOT MERGE Revert "WTF Logging for catching memory issue in Parcel" This reverts commit 101e38cbeceb0e1c0a27f1917d9ab0aabed26e49. Bug: 37298089 Change-Id: Ia468d50fd1e4ca2ffa6145967bf3c847ed1929b8 --- core/java/android/os/Parcel.java | 8 +------- core/jni/android_os_Parcel.cpp | 6 +----- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/core/java/android/os/Parcel.java b/core/java/android/os/Parcel.java index c5c743bc02948..28bdacfaea9c3 100644 --- a/core/java/android/os/Parcel.java +++ b/core/java/android/os/Parcel.java @@ -427,13 +427,7 @@ public final class Parcel { * @param size The new number of bytes in the Parcel. */ public final void setDataSize(int size) { - // STOPSHIP: Try/catch for exception is for temporary debug. Remove once bug resolved - try { - updateNativeSize(nativeSetDataSize(mNativePtr, size)); - } catch (IllegalArgumentException iae) { - Log.e(TAG,"Caught Exception representing a known bug in Parcel",iae); - Log.wtfStack(TAG, "This flow is using SetDataSize incorrectly"); - } + updateNativeSize(nativeSetDataSize(mNativePtr, size)); } /** diff --git a/core/jni/android_os_Parcel.cpp b/core/jni/android_os_Parcel.cpp index 56f68d4ecd059..d740a76f8c2ef 100644 --- a/core/jni/android_os_Parcel.cpp +++ b/core/jni/android_os_Parcel.cpp @@ -119,11 +119,7 @@ static jlong android_os_Parcel_setDataSize(JNIEnv* env, jclass clazz, jlong nati Parcel* parcel = reinterpret_cast(nativePtr); if (parcel != NULL) { const status_t err = parcel->setDataSize(size); - //STOPSHIP: check for BADFLO is for a temporary debug using wtf. Remove once bug resolved. - if (err == UNKNOWN_ERROR + 0xBADF10) { - jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", - "Attempt to resize (size = %d) Parcel would corrupt object memory", size); - } else if (err != NO_ERROR) { + if (err != NO_ERROR) { signalExceptionForError(env, clazz, err); } return parcel->getOpenAshmemSize();