Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge changes I0ababa6b,I1a1ad69b into tm-dev

Browse Source 
* changes:
  Run cancelAction if bouncer is canceled
  Fix bouncer flicker on lockscreen shade transition
This commit is contained in:
TreeHugger Robot
2022-05-24 21:49:10 +00:00
committed by Android (Google) Code Review
parent 4d6f731761 1de979862b
commit 27a45d8ec3
3 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/SystemUI/src/com/android/systemui/statusbar/phone/CentralSurfacesImpl.java
View File

@@ -107,7 +107,6 @@ import android.view.WindowManager;
import android.view.WindowManagerGlobal; import android.view.WindowManagerGlobal;
import android.view.accessibility.AccessibilityManager; import android.view.accessibility.AccessibilityManager;
import android.widget.DateTimeView; import android.widget.DateTimeView;
import android.window.SplashScreen;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.lifecycle.Lifecycle; import androidx.lifecycle.Lifecycle;
@@ -3508,11 +3507,6 @@ public class CentralSurfacesImpl extends CoreStartable implements
@Override @Override
public void onTrackingStopped(boolean expand) { public void onTrackingStopped(boolean expand) {
if (mState == StatusBarState.KEYGUARD || mState == StatusBarState.SHADE_LOCKED) {
if (!expand && !mKeyguardStateController.canDismissLockScreen()) {
mStatusBarKeyguardViewManager.showBouncer(false /* scrimmed */);
}
}
} }
// TODO: Figure out way to remove these. // TODO: Figure out way to remove these.

2
packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java
View File

@@ -480,12 +480,12 @@ public class StatusBarKeyguardViewManager implements RemoteInputController.Callb
if (mBouncer == null) { if (mBouncer == null) {
return; return;
} }
mBouncer.hide(destroyView);
if (mShowing) { if (mShowing) {
// If we were showing the bouncer and then aborting, we need to also clear out any // If we were showing the bouncer and then aborting, we need to also clear out any
// potential actions unless we actually unlocked. // potential actions unless we actually unlocked.
cancelPostAuthActions(); cancelPostAuthActions();
} }
mBouncer.hide(destroyView);
cancelPendingWakeupAction(); cancelPendingWakeupAction();
} }

15
packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManagerTest.java
View File

@@ -312,12 +312,27 @@ public class StatusBarKeyguardViewManagerTest extends SysuiTestCase {
mStatusBarKeyguardViewManager.dismissWithAction( mStatusBarKeyguardViewManager.dismissWithAction(
action, cancelAction, true /* afterKeyguardGone */); action, cancelAction, true /* afterKeyguardGone */);
when(mBouncer.isShowing()).thenReturn(false);
mStatusBarKeyguardViewManager.hideBouncer(true); mStatusBarKeyguardViewManager.hideBouncer(true);
mStatusBarKeyguardViewManager.hide(0, 30); mStatusBarKeyguardViewManager.hide(0, 30);
verify(action, never()).onDismiss(); verify(action, never()).onDismiss();
verify(cancelAction).run(); verify(cancelAction).run();
} }
@Test
public void testHidingBouncer_cancelsGoneRunnable() {
OnDismissAction action = mock(OnDismissAction.class);
Runnable cancelAction = mock(Runnable.class);
mStatusBarKeyguardViewManager.dismissWithAction(
action, cancelAction, true /* afterKeyguardGone */);
when(mBouncer.isShowing()).thenReturn(false);
mStatusBarKeyguardViewManager.hideBouncer(true);
verify(action, never()).onDismiss();
verify(cancelAction).run();
}
@Test @Test
public void testHiding_doesntCancelWhenShowing() { public void testHiding_doesntCancelWhenShowing() {
OnDismissAction action = mock(OnDismissAction.class); OnDismissAction action = mock(OnDismissAction.class);