From 07fe83332f39735f7e74fce2bc115398e3546890 Mon Sep 17 00:00:00 2001 From: Edward Cunningham Date: Wed, 31 Mar 2021 21:40:23 +0000 Subject: [PATCH] Show indeterminate progess when installing. Bug: 183969627 Test: manual Change-Id: I3ea3de2f1c55d4a21d9ab15b5d56b707512c5477 --- .../res/layout/install_content_view.xml | 3 +- .../packageinstaller/InstallInstalling.java | 52 ------------------- 2 files changed, 2 insertions(+), 53 deletions(-) diff --git a/packages/PackageInstaller/res/layout/install_content_view.xml b/packages/PackageInstaller/res/layout/install_content_view.xml index 5e94a29a63991..8e909c4509ae7 100644 --- a/packages/PackageInstaller/res/layout/install_content_view.xml +++ b/packages/PackageInstaller/res/layout/install_content_view.xml @@ -65,7 +65,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:paddingTop="8dp" - style="?android:attr/progressBarStyleHorizontal" /> + style="?android:attr/progressBarStyleHorizontal" + android:indeterminate="true" /> diff --git a/packages/PackageInstaller/src/com/android/packageinstaller/InstallInstalling.java b/packages/PackageInstaller/src/com/android/packageinstaller/InstallInstalling.java index 935cb372029d0..1d0ae9912d972 100755 --- a/packages/PackageInstaller/src/com/android/packageinstaller/InstallInstalling.java +++ b/packages/PackageInstaller/src/com/android/packageinstaller/InstallInstalling.java @@ -35,7 +35,6 @@ import android.os.Bundle; import android.util.Log; import android.view.View; import android.widget.Button; -import android.widget.ProgressBar; import com.android.internal.app.AlertActivity; import com.android.internal.content.PackageHelper; @@ -61,9 +60,6 @@ public class InstallInstalling extends AlertActivity { private static final String BROADCAST_ACTION = "com.android.packageinstaller.ACTION_INSTALL_COMMIT"; - /** Listens to changed to the session and updates progress bar */ - private PackageInstaller.SessionCallback mSessionCallback; - /** Task that sends the package to the package installer */ private InstallingAsyncTask mInstallingTask; @@ -185,8 +181,6 @@ public class InstallInstalling extends AlertActivity { } mCancelButton = mAlert.getButton(DialogInterface.BUTTON_NEGATIVE); - - mSessionCallback = new InstallSessionCallback(); } } @@ -221,13 +215,6 @@ public class InstallInstalling extends AlertActivity { finish(); } - @Override - protected void onStart() { - super.onStart(); - - getPackageManager().getPackageInstaller().registerSessionCallback(mSessionCallback); - } - @Override protected void onResume() { super.onResume(); @@ -263,13 +250,6 @@ public class InstallInstalling extends AlertActivity { } } - @Override - protected void onStop() { - super.onStop(); - - getPackageManager().getPackageInstaller().unregisterSessionCallback(mSessionCallback); - } - @Override protected void onDestroy() { if (mInstallingTask != null) { @@ -306,38 +286,6 @@ public class InstallInstalling extends AlertActivity { } } - - private class InstallSessionCallback extends PackageInstaller.SessionCallback { - @Override - public void onCreated(int sessionId) { - // empty - } - - @Override - public void onBadgingChanged(int sessionId) { - // empty - } - - @Override - public void onActiveChanged(int sessionId, boolean active) { - // empty - } - - @Override - public void onProgressChanged(int sessionId, float progress) { - if (sessionId == mSessionId) { - ProgressBar progressBar = requireViewById(R.id.progress); - progressBar.setMax(Integer.MAX_VALUE); - progressBar.setProgress((int) (Integer.MAX_VALUE * progress)); - } - } - - @Override - public void onFinished(int sessionId, boolean success) { - // empty, finish is handled by InstallResultReceiver - } - } - /** * Send the package to the package installer and then register a event result observer that * will call {@link #launchFinishBasedOnResult(int, int, String)}