Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Avoid throwing when 0 size layer requested" into nyc-mr1-dev

Browse Source
This commit is contained in:
Chris Craik
2016-07-11 21:18:20 +00:00
committed by Android (Google) Code Review
parent b646ec13e1 e3e481df76
commit 272b827925
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/hwui/RenderNode.cpp
View File

@@ -301,7 +301,10 @@ void RenderNode::pushLayerUpdate(TreeInfo& info) {
LayerType layerType = properties().effectiveLayerType();
// If we are not a layer OR we cannot be rendered (eg, view was detached)
// we need to destroy any Layers we may have had previously
if (CC_LIKELY(layerType != LayerType::RenderLayer) || CC_UNLIKELY(!isRenderable())) {
if (CC_LIKELY(layerType != LayerType::RenderLayer)
|| CC_UNLIKELY(!isRenderable())
|| CC_UNLIKELY(properties().getWidth() == 0)
|| CC_UNLIKELY(properties().getHeight() == 0)) {
if (CC_UNLIKELY(mLayer)) {
destroyLayer(mLayer);
mLayer = nullptr;

4
libs/hwui/RenderProperties.h
View File

@@ -611,9 +611,7 @@ public:
bool fitsOnLayer() const {
const DeviceInfo* deviceInfo = DeviceInfo::get();
return mPrimitiveFields.mWidth <= deviceInfo->maxTextureSize()
&& mPrimitiveFields.mHeight <= deviceInfo->maxTextureSize()
&& mPrimitiveFields.mWidth > 0
&& mPrimitiveFields.mHeight > 0;
&& mPrimitiveFields.mHeight <= deviceInfo->maxTextureSize();
}
bool promotedToLayer() const {

4
libs/hwui/tests/unit/RenderPropertiesTests.cpp
View File

@@ -42,7 +42,7 @@ TEST(RenderProperties, layerValidity) {
props.setLeftTopRightBottom(0, 0, maxTextureSize + 1, maxTextureSize + 1);
ASSERT_FALSE(props.fitsOnLayer());
// Too small - can't have 0 dimen layer
// Too small, but still 'fits'. Not fitting is an error case, so don't report empty as such.
props.setLeftTopRightBottom(0, 0, 100, 0);
ASSERT_FALSE(props.fitsOnLayer());
ASSERT_TRUE(props.fitsOnLayer());
}