From 9c72d6ee0abfb3708cd540a39215eec11869dfd7 Mon Sep 17 00:00:00 2001
From: Dave Mankoff <mankoff@google.com>
Date: Wed, 26 May 2021 14:21:44 -0400
Subject: [PATCH] Visual changes to tap-again toast.

Smaller margins.
New text and bg color.
Update colors when switching to dark theme.
Lower elevation.
New text.

Bug: 188895666
Test: manual
Change-Id: I10fae63037994c3e6fcd91f989faee4828df55ed
---
 .../SystemUI/res/layout/status_bar_expanded.xml | 11 ++++++-----
 packages/SystemUI/res/values/strings.xml        |  3 +++
 .../systemui/statusbar/phone/TapAgainView.java  | 17 ++++++++---------
 .../statusbar/phone/TapAgainViewController.java |  6 +++---
 4 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/packages/SystemUI/res/layout/status_bar_expanded.xml b/packages/SystemUI/res/layout/status_bar_expanded.xml
index 09d46856dec80..fb39d3e4027d5 100644
--- a/packages/SystemUI/res/layout/status_bar_expanded.xml
+++ b/packages/SystemUI/res/layout/status_bar_expanded.xml
@@ -137,11 +137,12 @@
             systemui:layout_constraintRight_toRightOf="parent"
             systemui:layout_constraintBottom_toBottomOf="parent"
             android:layout_marginBottom="20dp"
-            android:paddingLeft="20dp"
-            android:paddingRight="20dp"
-            android:paddingTop="10dp"
-            android:paddingBottom="10dp"
-            android:elevation="10dp"
+            android:paddingHorizontal="16dp"
+            android:minHeight="44dp"
+            android:elevation="4dp"
+            android:background="@drawable/rounded_bg_full"
+            android:gravity="center"
+            android:text="@string/tap_again"
             android:visibility="gone"
         />
     </com.android.systemui.statusbar.phone.NotificationsQuickSettingsContainer>
diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml
index 01d0dde6da5e3..db3fae6fa491c 100644
--- a/packages/SystemUI/res/values/strings.xml
+++ b/packages/SystemUI/res/values/strings.xml
@@ -1062,6 +1062,9 @@
     <!-- Shows to explain the double tap interaction with notifications: After tapping a notification on Keyguard, this will explain users to tap again to launch a notification. [CHAR LIMIT=60] -->
     <string name="notification_tap_again">Tap again to open</string>
 
+    <!-- Asks for a second tap as confirmation on an item that normally requires one tap. [CHAR LIMIT=60] -->
+    <string name="tap_again">Tap again</string>
+
     <!-- Message shown when lock screen is tapped or face authentication fails. [CHAR LIMIT=60] -->
     <string name="keyguard_unlock">Swipe up to open</string>
 
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainView.java
index 9856795c89039..52e0e8a7a0cb6 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainView.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainView.java
@@ -23,7 +23,6 @@ import android.animation.ObjectAnimator;
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.View;
-import android.widget.FrameLayout;
 import android.widget.TextView;
 
 import androidx.annotation.NonNull;
@@ -35,24 +34,24 @@ import com.android.wm.shell.animation.Interpolators;
 /**
  * View to show a toast-like popup on the notification shade and quick settings.
  */
-public class TapAgainView extends FrameLayout {
+public class TapAgainView extends TextView {
+    private TextView mTextView;
+
     public TapAgainView(
             @NonNull Context context, @Nullable AttributeSet attrs) {
         super(context, attrs);
-        updateBgColor();
     }
 
     @Override
     protected void onFinishInflate() {
         super.onFinishInflate();
-
-        TextView text = new TextView(mContext);
-        text.setText(R.string.notification_tap_again);
-        addView(text);
+        updateColor();
     }
 
-    void updateBgColor() {
-        setBackgroundResource(R.drawable.rounded_bg_full);
+    void updateColor() {
+        int textColor = getResources().getColor(R.color.notif_pill_text, mContext.getTheme());
+        setTextColor(textColor);
+        setBackground(getResources().getDrawable(R.drawable.rounded_bg_full, mContext.getTheme()));
     }
 
     /** Make the view visible. */
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainViewController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainViewController.java
index bb53bad7df70c..0c5502bac8fc0 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainViewController.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/TapAgainViewController.java
@@ -44,17 +44,17 @@ public class TapAgainViewController extends ViewController<TapAgainView> {
     final ConfigurationListener mConfigurationListener = new ConfigurationListener() {
         @Override
         public void onOverlayChanged() {
-            mView.updateBgColor();
+            mView.updateColor();
         }
 
         @Override
         public void onUiModeChanged() {
-            mView.updateBgColor();
+            mView.updateColor();
         }
 
         @Override
         public void onThemeChanged() {
-            mView.updateBgColor();
+            mView.updateColor();
         }
     };