Merge "Remove unnecessary WTFs from password state check" into pi-dev

This commit is contained in:
Eran Messeri
2018-04-25 09:28:15 +00:00
committed by Android (Google) Code Review

View File

@@ -3961,8 +3961,6 @@ public class DevicePolicyManagerService extends BaseIDevicePolicyManager {
DevicePolicyData policy = getUserData(credentialOwner);
PasswordMetrics metrics = getUserPasswordMetricsLocked(credentialOwner);
if (metrics == null) {
Slog.wtf(LOG_TAG, "Should have had a valid password metrics for updating checkpoint " +
"validity.");
metrics = new PasswordMetrics();
}
policy.mPasswordValidAtLastCheckpoint =
@@ -4511,7 +4509,8 @@ public class DevicePolicyManagerService extends BaseIDevicePolicyManager {
}
if (metrics == null) {
Slog.wtf(LOG_TAG, "FBE device, should have been unlocked and had valid metrics.");
// This could happen if the user never had a password set, for example, so
// setActivePasswordState has never been called for it.
metrics = new PasswordMetrics();
}
return isPasswordSufficientForUserWithoutCheckpointLocked(metrics, userHandle, parent);