From a2a6eb07543961a506988289ff5448498c2ee780 Mon Sep 17 00:00:00 2001 From: Chandru Date: Fri, 5 Aug 2022 12:04:30 +0000 Subject: [PATCH] Migrate 2 missed-out usages of Log.* to LogBuffer Bug: 239819049 Test: NA Change-Id: I17f7f28db2c0e7811fb14aee5e484f6fbf6b0b9c --- .../com/android/keyguard/KeyguardUpdateMonitor.java | 9 ++++----- .../keyguard/logging/KeyguardUpdateMonitorLogger.kt | 11 ++++++++++- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java b/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java index 98946ac5b0eec..6bac7dc5fb944 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardUpdateMonitor.java @@ -87,7 +87,6 @@ import android.telephony.SubscriptionManager.OnSubscriptionsChangedListener; import android.telephony.TelephonyCallback; import android.telephony.TelephonyManager; import android.text.TextUtils; -import android.util.Log; import android.util.SparseArray; import android.util.SparseBooleanArray; @@ -730,7 +729,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab private void handleFingerprintAuthFailed() { Assert.isMainThread(); if (mHandler.hasCallbacks(mFpCancelNotReceived)) { - Log.d(TAG, "handleFingerprintAuthFailed()" + mLogger.d("handleFingerprintAuthFailed()" + " triggered while waiting for cancellation, removing watchdog"); mHandler.removeCallbacks(mFpCancelNotReceived); } @@ -765,7 +764,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab private void handleFingerprintAuthenticated(int authUserId, boolean isStrongBiometric) { Trace.beginSection("KeyGuardUpdateMonitor#handlerFingerPrintAuthenticated"); if (mHandler.hasCallbacks(mFpCancelNotReceived)) { - Log.d(TAG, "handleFingerprintAuthenticated()" + mLogger.d("handleFingerprintAuthenticated()" + " triggered while waiting for cancellation, removing watchdog"); mHandler.removeCallbacks(mFpCancelNotReceived); } @@ -840,7 +839,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab if (msgId == FingerprintManager.FINGERPRINT_ERROR_HW_UNAVAILABLE || msgId == FingerprintManager.BIOMETRIC_ERROR_POWER_PRESSED) { - Log.d(TAG, "Fingerprint retrying auth due to(" + msgId + ") -> " + errString); + mLogger.logRetryAfterFpError(msgId, errString); mHandler.postDelayed(mRetryFingerprintAuthentication, HAL_ERROR_RETRY_TIMEOUT); } @@ -3418,7 +3417,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab mHandler.sendMessage(mHandler.obtainMessage(MSG_ASSISTANT_STACK_CHANGED, info.visible)); } catch (RemoteException e) { - Log.e(TAG, "unable to check task stack", e); + mLogger.logException(e, "unable to check task stack "); } } }; diff --git a/packages/SystemUI/src/com/android/keyguard/logging/KeyguardUpdateMonitorLogger.kt b/packages/SystemUI/src/com/android/keyguard/logging/KeyguardUpdateMonitorLogger.kt index 035b7f07a5f45..d718a240bbfd3 100644 --- a/packages/SystemUI/src/com/android/keyguard/logging/KeyguardUpdateMonitorLogger.kt +++ b/packages/SystemUI/src/com/android/keyguard/logging/KeyguardUpdateMonitorLogger.kt @@ -198,6 +198,15 @@ class KeyguardUpdateMonitorLogger @Inject constructor( { "Retrying face after HW unavailable, attempt $int1" }) } + fun logRetryAfterFpError(msgId: Int, errString: String?) { + logBuffer.log(TAG, DEBUG, { + int1 = msgId + str1 = "$errString" + }, { + "Fingerprint retrying auth due to($int1) -> $str1" + }) + } + fun logRetryAfterFpHwUnavailable(retryCount: Int) { logBuffer.log(TAG, WARNING, { int1 = retryCount }, @@ -270,12 +279,12 @@ class KeyguardUpdateMonitorLogger @Inject constructor( { str1 = newTimeFormat }, { "handleTimeFormatUpdate timeFormat=$str1" }) } - fun logUdfpsPointerDown(sensorId: Int) { logBuffer.log(TAG, DEBUG, { int1 = sensorId }, { "onUdfpsPointerDown, sensorId: $int1" }) } + fun logUdfpsPointerUp(sensorId: Int) { logBuffer.log(TAG, DEBUG, { int1 = sensorId },