From 9a44cd1d153c22274476dcf39ef15abbc6c5f19b Mon Sep 17 00:00:00 2001 From: Tim Murray Date: Wed, 5 Oct 2022 12:19:14 -0700 Subject: [PATCH] WindowManager: improve focused app tracing Move focused app trace sections to a single track and include the activity name as well. Test: trace names appear Bug: 250614152 Change-Id: Ie8b2ca8681323d8bb68783553c991462dbffb59c --- .../server/wm/ActivityTaskManagerService.java | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/services/core/java/com/android/server/wm/ActivityTaskManagerService.java b/services/core/java/com/android/server/wm/ActivityTaskManagerService.java index 4ecc62923c5df..57894f6769cbb 100644 --- a/services/core/java/com/android/server/wm/ActivityTaskManagerService.java +++ b/services/core/java/com/android/server/wm/ActivityTaskManagerService.java @@ -5041,21 +5041,20 @@ public class ActivityTaskManagerService extends IActivityTaskManager.Stub { } private void updateResumedAppTrace(@Nullable ActivityRecord resumed) { - if (mTracedResumedActivity != null) { - Trace.asyncTraceEnd(TRACE_TAG_WINDOW_MANAGER, - constructResumedTraceName(mTracedResumedActivity.packageName), 0); - } - if (resumed != null) { - Trace.asyncTraceBegin(TRACE_TAG_WINDOW_MANAGER, - constructResumedTraceName(resumed.packageName), 0); + if (Trace.isTagEnabled(Trace.TRACE_TAG_WINDOW_MANAGER)) { + if (mTracedResumedActivity != null) { + Trace.asyncTraceForTrackEnd(TRACE_TAG_WINDOW_MANAGER, + "Focused app", System.identityHashCode(mTracedResumedActivity)); + } + if (resumed != null) { + Trace.asyncTraceForTrackBegin(TRACE_TAG_WINDOW_MANAGER, + "Focused app", resumed.mActivityComponent.flattenToShortString(), + System.identityHashCode(resumed)); + } } mTracedResumedActivity = resumed; } - private String constructResumedTraceName(String packageName) { - return "focused app: " + packageName; - } - /** Applies latest configuration and/or visibility updates if needed. */ boolean ensureConfigAndVisibilityAfterUpdate(ActivityRecord starting, int changes) { boolean kept = true;