Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Remove NotificationVisibility storage pool"

Browse Source
This commit is contained in:
Hans Boehm
2018-10-22 20:20:38 +00:00
committed by Gerrit Code Review
parent cbcaabedfd 2aa911c01e
commit 24141e8124
1 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
core/java/com/android/internal/statusbar/NotificationVisibility.java
View File

@@ -27,7 +27,6 @@ import java.util.Collection;
public class NotificationVisibility implements Parcelable { public class NotificationVisibility implements Parcelable {
private static final String TAG = "NoViz"; private static final String TAG = "NoViz";
private static final int MAX_POOL_SIZE = 25; private static final int MAX_POOL_SIZE = 25;
private static ArrayDeque<NotificationVisibility> sPool = new ArrayDeque<>(MAX_POOL_SIZE);
private static int sNexrId = 0; private static int sNexrId = 0;
public String key; public String key;
@@ -119,11 +118,6 @@ public class NotificationVisibility implements Parcelable {
} }
private static NotificationVisibility obtain() { private static NotificationVisibility obtain() {
synchronized (sPool) {
if (!sPool.isEmpty()) {
return sPool.poll();
}
}
return new NotificationVisibility(); return new NotificationVisibility();
} }
@@ -135,16 +129,7 @@ public class NotificationVisibility implements Parcelable {
* </p> * </p>
*/ */
public void recycle() { public void recycle() {
if (key == null) { // With a modern GC, this is no longer useful for objects this small.
// do nothing on multiple recycles
return;
}
key = null;
if (sPool.size() < MAX_POOL_SIZE) {
synchronized (sPool) {
sPool.offer(this);
}
}
} }
/** /**