diff --git a/packages/SystemUI/res/xml/qs_header.xml b/packages/SystemUI/res/xml/qs_header.xml index 8248fcdb50fb9..982c422f1fda2 100644 --- a/packages/SystemUI/res/xml/qs_header.xml +++ b/packages/SystemUI/res/xml/qs_header.xml @@ -21,51 +21,105 @@ android:id="@+id/qs_header_constraint" > + + + + + - - + + + android:id="@+id/statusIcons"> + + + + + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintHorizontal_bias="1" + app:layout_constraintHorizontal_chainStyle="spread_inside" + /> + + + + + \ No newline at end of file diff --git a/packages/SystemUI/res/xml/qs_header_new.xml b/packages/SystemUI/res/xml/qs_header_new.xml deleted file mode 100644 index 982c422f1fda2..0000000000000 --- a/packages/SystemUI/res/xml/qs_header_new.xml +++ /dev/null @@ -1,125 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt index 2463b0c91d25d..8c7ad72df56ed 100644 --- a/packages/SystemUI/src/com/android/systemui/flags/Flags.kt +++ b/packages/SystemUI/src/com/android/systemui/flags/Flags.kt @@ -181,9 +181,6 @@ object Flags { "qs_user_detail_shortcut" ) - // TODO(b/254512747): Tracking Bug - val NEW_HEADER = releasedFlag(505, "new_header") - // TODO(b/254512383): Tracking Bug @JvmField val FULL_SCREEN_USER_SWITCHER = diff --git a/packages/SystemUI/src/com/android/systemui/shade/LargeScreenShadeHeaderController.kt b/packages/SystemUI/src/com/android/systemui/shade/LargeScreenShadeHeaderController.kt index 63d0d169e8742..31e44646859f0 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/LargeScreenShadeHeaderController.kt +++ b/packages/SystemUI/src/com/android/systemui/shade/LargeScreenShadeHeaderController.kt @@ -331,13 +331,8 @@ class LargeScreenShadeHeaderController @Inject constructor( // Use resources.getXml instead of passing the resource id due to bug b/205018300 header.getConstraintSet(QQS_HEADER_CONSTRAINT) .load(context, resources.getXml(R.xml.qqs_header)) - val qsConstraints = if (featureFlags.isEnabled(Flags.NEW_HEADER)) { - R.xml.qs_header_new - } else { - R.xml.qs_header - } header.getConstraintSet(QS_HEADER_CONSTRAINT) - .load(context, resources.getXml(qsConstraints)) + .load(context, resources.getXml(R.xml.qs_header)) header.getConstraintSet(LARGE_SCREEN_HEADER_CONSTRAINT) .load(context, resources.getXml(R.xml.large_screen_shade_header)) } diff --git a/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt b/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt index bc17c19df8f50..2a3d32e07b91b 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt @@ -43,7 +43,7 @@ class CombinedShadeHeaderConstraintsTest : SysuiTestCase() { load(context, context.resources.getXml(R.xml.qqs_header)) } qsConstraint = ConstraintSet().apply { - load(context, context.resources.getXml(R.xml.qs_header_new)) + load(context, context.resources.getXml(R.xml.qs_header)) } largeScreenConstraint = ConstraintSet().apply { load(context, context.resources.getXml(R.xml.large_screen_shade_header)) diff --git a/packages/SystemUI/tests/src/com/android/systemui/shade/LargeScreenShadeHeaderControllerCombinedTest.kt b/packages/SystemUI/tests/src/com/android/systemui/shade/LargeScreenShadeHeaderControllerCombinedTest.kt index 14a3bc147808b..e1007faae88b7 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/shade/LargeScreenShadeHeaderControllerCombinedTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/shade/LargeScreenShadeHeaderControllerCombinedTest.kt @@ -179,7 +179,6 @@ class LargeScreenShadeHeaderControllerCombinedTest : SysuiTestCase() { whenever(iconManagerFactory.create(any(), any())).thenReturn(iconManager) whenever(featureFlags.isEnabled(Flags.COMBINED_QS_HEADERS)).thenReturn(true) - whenever(featureFlags.isEnabled(Flags.NEW_HEADER)).thenReturn(true) setUpDefaultInsets() setUpMotionLayout(view) @@ -212,7 +211,7 @@ class LargeScreenShadeHeaderControllerCombinedTest : SysuiTestCase() { assertThat(captor.value.getResId()).isEqualTo(R.xml.qqs_header) verify(qsConstraints).load(eq(context), capture(captor)) - assertThat(captor.value.getResId()).isEqualTo(R.xml.qs_header_new) + assertThat(captor.value.getResId()).isEqualTo(R.xml.qs_header) verify(largeScreenConstraints).load(eq(context), capture(captor)) assertThat(captor.value.getResId()).isEqualTo(R.xml.large_screen_shade_header)