Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Revert "Revert "[SettingsProvider] skip caching in system server""" into udc-dev

Browse Source
This commit is contained in:
Song Chun Fan
2023-05-08 16:52:11 +00:00
committed by Android (Google) Code Review
parent 3fac471cfc caeb19048d
commit 23cdcba71c
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/java/android/provider/Settings.java
View File

@@ -3036,9 +3036,7 @@ public final class Settings {
public void destroy() { public void destroy() {
try { try {
// If this process is the system server process, mArray is the same object as if (!mArray.isClosed()) {
// the memory int array kept inside SettingsProvider, so skipping the close()
if (!Settings.isInSystemServer() && !mArray.isClosed()) {
mArray.close(); mArray.close();
} }
} catch (IOException e) { } catch (IOException e) {
@@ -3218,8 +3216,9 @@ public final class Settings {
@UnsupportedAppUsage @UnsupportedAppUsage
public String getStringForUser(ContentResolver cr, String name, final int userHandle) { public String getStringForUser(ContentResolver cr, String name, final int userHandle) {
final boolean isSelf = (userHandle == UserHandle.myUserId()); final boolean isSelf = (userHandle == UserHandle.myUserId());
final boolean useCache = isSelf && !isInSystemServer();
boolean needsGenerationTracker = false; boolean needsGenerationTracker = false;
if (isSelf) { if (useCache) {
synchronized (NameValueCache.this) { synchronized (NameValueCache.this) {
final GenerationTracker generationTracker = mGenerationTrackers.get(name); final GenerationTracker generationTracker = mGenerationTrackers.get(name);
if (generationTracker != null) { if (generationTracker != null) {
@@ -3365,9 +3364,12 @@ public final class Settings {
} }
} }
} else { } else {
if (LOCAL_LOGV) Log.i(TAG, "call-query of user " + userHandle if (DEBUG || LOCAL_LOGV) {
+ " by " + UserHandle.myUserId() Log.i(TAG, "call-query of user " + userHandle
+ " so not updating cache"); + " by " + UserHandle.myUserId()
+ (isInSystemServer() ? " in system_server" : "")
+ " so not updating cache");
}
} }
return value; return value;
} }