Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AAPT2: Fix R.java for styleable in different package

Browse Source 
When generating the R.java file, attributes of styleables do not always
have package names on them. This caused a problem where when an apk
that was previously linked and that also contained a declare-styleable
is linked again to an AndroidManifest.xml with a different package name,
styleable attributes' resource symbols could not be looked up correctly.

This change does not rename the resources but makes sure that the java
generator finds the attribute symbols correctly.

Bug: 110877419
Test: Created a test in aapt2_tests and verified correct behavior of
repro example from bug

Change-Id: Ib99d84cbe44dadca86603bc610ad3f4e09e3fb11
This commit is contained in:
Ryan Mitchell
2018-07-12 17:16:40 -07:00
parent 53208af20d
commit 23cc5d5dbe
2 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/aapt2/java/JavaClassGenerator.cpp
View File

@@ -256,9 +256,20 @@ void JavaClassGenerator::ProcessStyleable(const ResourceNameRef& name, const Res
styleable_attr.field_name =
TransformNestedAttr(attr.name.value(), array_field_name, package_name_to_generate);
Reference ref = attr;
if (attr.name.value().package.empty()) {
// If the resource does not have a package name, set the package to the unmangled package name
// of the styleable declaration because attributes without package names would have been
// declared in the same package as the styleable.
ref.name = ResourceName(package_name_to_generate, ref.name.value().type,
ref.name.value().entry);
}
// Look up the symbol so that we can write out in the comments what are possible legal values
// for this attribute.
const SymbolTable::Symbol* symbol = context_->GetExternalSymbols()->FindByReference(attr);
const SymbolTable::Symbol* symbol = context_->GetExternalSymbols()->FindByReference(ref);
if (symbol && symbol->attribute) {
// Copy the symbol data structure because the returned instance can be destroyed.
styleable_attr.symbol = *symbol;
@@ -303,7 +314,7 @@ void JavaClassGenerator::ProcessStyleable(const ResourceNameRef& name, const Res
const ResourceName& attr_name = entry.attr_ref->name.value();
styleable_comment << "<tr><td><code>{@link #" << entry.field_name << " "
<< (!attr_name.package.empty() ? attr_name.package
: context_->GetCompilationPackage())
: package_name_to_generate)
<< ":" << attr_name.entry << "}</code></td>";
// Only use the comment up until the first '.'. This is to stay compatible with
@@ -374,7 +385,7 @@ void JavaClassGenerator::ProcessStyleable(const ResourceNameRef& name, const Res
StringPiece package_name = attr_name.package;
if (package_name.empty()) {
package_name = context_->GetCompilationPackage();
package_name = package_name_to_generate;
}
std::unique_ptr<IntMember> index_member =