From 74f4ed7700001a014ac444ed082e3b143d56e266 Mon Sep 17 00:00:00 2001 From: Nataniel Borges Date: Thu, 2 Feb 2023 11:34:08 +0000 Subject: [PATCH] Ignore assumption violation errors on IW cuj The issue started when the shell transitions flag was updated. To avoid this in the future, add cujComplete tests to regular flicker presubmit to block CLs that break it Test: atest FlickerTests Fixes: 267564965 Change-Id: I4525775fcfd19e6713974cafbb964553580fb125 --- .../src/com/android/server/wm/flicker/BaseTest.kt | 12 ++++++------ .../server/wm/flicker/ime/CloseImeOnGoHomeTest.kt | 1 + .../wm/flicker/ime/CloseImeToAppOnPressBackTest.kt | 1 + .../ime/CloseImeToHomeOnFinishActivityTest.kt | 1 + .../ime/ShowImeWhenFocusingOnInputFieldTest.kt | 1 + 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/BaseTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/BaseTest.kt index 64ed45307e8db..73b5afef5ec34 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/BaseTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/BaseTest.kt @@ -184,12 +184,12 @@ constructor( } open fun cujCompleted() { - entireScreenCovered() - statusBarLayerIsVisibleAtStartAndEnd() - statusBarLayerPositionAtStartAndEnd() - statusBarWindowIsAlwaysVisible() - visibleLayersShownMoreThanOneConsecutiveEntry() - visibleWindowsShownMoreThanOneConsecutiveEntry() + runAndIgnoreAssumptionViolation { entireScreenCovered() } + runAndIgnoreAssumptionViolation { statusBarLayerIsVisibleAtStartAndEnd() } + runAndIgnoreAssumptionViolation { statusBarLayerPositionAtStartAndEnd() } + runAndIgnoreAssumptionViolation { statusBarWindowIsAlwaysVisible() } + runAndIgnoreAssumptionViolation { visibleLayersShownMoreThanOneConsecutiveEntry() } + runAndIgnoreAssumptionViolation { visibleWindowsShownMoreThanOneConsecutiveEntry() } runAndIgnoreAssumptionViolation { taskBarLayerIsVisibleAtStartAndEnd() } runAndIgnoreAssumptionViolation { taskBarWindowIsAlwaysVisible() } runAndIgnoreAssumptionViolation { navBarLayerIsVisibleAtStartAndEnd() } diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnGoHomeTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnGoHomeTest.kt index b40720b1467f9..4890bbae805a9 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnGoHomeTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeOnGoHomeTest.kt @@ -100,6 +100,7 @@ open class CloseImeOnGoHomeTest(flicker: FlickerTest) : BaseTest(flicker) { flicker.assertLayers { this.isVisible(testApp).then().isInvisible(testApp) } } + @Presubmit @Test @IwTest(focusArea = "ime") override fun cujCompleted() { diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToAppOnPressBackTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToAppOnPressBackTest.kt index f6838f488232e..63f7200647da6 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToAppOnPressBackTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToAppOnPressBackTest.kt @@ -102,6 +102,7 @@ open class CloseImeToAppOnPressBackTest(flicker: FlickerTest) : BaseTest(flicker flicker.assertWm { this.isAppWindowOnTop(testApp) } } + @Presubmit @Test @IwTest(focusArea = "ime") override fun cujCompleted() { diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToHomeOnFinishActivityTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToHomeOnFinishActivityTest.kt index a744cd76a05e9..0b7b165aaad68 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToHomeOnFinishActivityTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/CloseImeToHomeOnFinishActivityTest.kt @@ -79,6 +79,7 @@ open class CloseImeToHomeOnFinishActivityTest(flicker: FlickerTest) : BaseTest(f super.visibleLayersShownMoreThanOneConsecutiveEntry() } + @Presubmit @Test @IwTest(focusArea = "ime") override fun cujCompleted() { diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/ShowImeWhenFocusingOnInputFieldTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/ShowImeWhenFocusingOnInputFieldTest.kt index 36747cc7d69a7..851651eea91cd 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/ime/ShowImeWhenFocusingOnInputFieldTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/ime/ShowImeWhenFocusingOnInputFieldTest.kt @@ -50,6 +50,7 @@ open class ShowImeWhenFocusingOnInputFieldTest(flicker: FlickerTest) : BaseTest( } } + @Presubmit @Test @IwTest(focusArea = "ime") override fun cujCompleted() {