From 76c01a50d3028d9db251d7fc8bc5dbab1879d493 Mon Sep 17 00:00:00 2001 From: Tyler Gunn Date: Tue, 30 Sep 2014 14:47:51 -0700 Subject: [PATCH] MR1 - Adding more Telecom state dumping. - Add toString for PhoneAccount class for use when dumping state. - Call Log.pii for PhoneAccountHandle mId since it may contain pii (eg sip uri). Bug: 17730966 Change-Id: Iddbd949b42704405de558f8ed8c4449242b74870 --- telecomm/java/android/telecom/PhoneAccount.java | 15 +++++++++++++++ .../java/android/telecom/PhoneAccountHandle.java | 4 +++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/telecomm/java/android/telecom/PhoneAccount.java b/telecomm/java/android/telecom/PhoneAccount.java index 062baa54de2c1..66b52ae1df20a 100644 --- a/telecomm/java/android/telecom/PhoneAccount.java +++ b/telecomm/java/android/telecom/PhoneAccount.java @@ -451,4 +451,19 @@ public class PhoneAccount implements Parcelable { in.readList(supportedUriSchemes, classLoader); mSupportedUriSchemes = Collections.unmodifiableList(supportedUriSchemes); } + + @Override + public String toString() { + StringBuilder sb = new StringBuilder().append("[PhoneAccount: ") + .append(mAccountHandle) + .append(" Capabilities: ") + .append(mCapabilities) + .append(" Schemes: "); + for (String scheme : mSupportedUriSchemes) { + sb.append(scheme) + .append(" "); + } + sb.append("]"); + return sb.toString(); + } } diff --git a/telecomm/java/android/telecom/PhoneAccountHandle.java b/telecomm/java/android/telecom/PhoneAccountHandle.java index e13df7685d6d5..768188b81c498 100644 --- a/telecomm/java/android/telecom/PhoneAccountHandle.java +++ b/telecomm/java/android/telecom/PhoneAccountHandle.java @@ -71,9 +71,11 @@ public class PhoneAccountHandle implements Parcelable { @Override public String toString() { + // Note: Log.pii called for mId as it can contain personally identifying phone account + // information such as SIP account IDs. return new StringBuilder().append(mComponentName) .append(", ") - .append(mId) + .append(Log.pii(mId)) .toString(); }