From 7a2b535afc17cb0d7b5b559d7895322709158920 Mon Sep 17 00:00:00 2001 From: lpeter Date: Thu, 9 Apr 2020 15:31:43 +0800 Subject: [PATCH] Request the IME to hide current inline suggestion Request the IME to hide current inline suggestion on committing. Bug: 149945531 Test: atest InlineLoginActivityTest Test: atest InlineAugmentedLoginActivityTest Change-Id: Ia19aebb7d84c6d858fa93ee51df1bbbf7d92eafe --- .../server/autofill/RemoteAugmentedAutofillService.java | 3 +++ .../autofill/java/com/android/server/autofill/Session.java | 2 ++ 2 files changed, 5 insertions(+) diff --git a/services/autofill/java/com/android/server/autofill/RemoteAugmentedAutofillService.java b/services/autofill/java/com/android/server/autofill/RemoteAugmentedAutofillService.java index 8b50b010a22c0..b6bc7c5646a53 100644 --- a/services/autofill/java/com/android/server/autofill/RemoteAugmentedAutofillService.java +++ b/services/autofill/java/com/android/server/autofill/RemoteAugmentedAutofillService.java @@ -58,6 +58,7 @@ import com.android.internal.os.IResultReceiver; import com.android.server.autofill.ui.InlineSuggestionFactory; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.concurrent.CancellationException; import java.util.concurrent.TimeUnit; @@ -263,6 +264,8 @@ final class RemoteAugmentedAutofillService && fieldIds.get(0).equals(focusedId); client.autofill(sessionId, fieldIds, dataset.getFieldValues(), hideHighlight); + inlineSuggestionsCallback.apply(new InlineSuggestionsResponse( + Collections.EMPTY_LIST)); } catch (RemoteException e) { Slog.w(TAG, "Encounter exception autofilling the values"); } diff --git a/services/autofill/java/com/android/server/autofill/Session.java b/services/autofill/java/com/android/server/autofill/Session.java index 4ecffd8d29b03..78b943cb464b9 100644 --- a/services/autofill/java/com/android/server/autofill/Session.java +++ b/services/autofill/java/com/android/server/autofill/Session.java @@ -1228,6 +1228,8 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState } catch (RemoteException e) { Slog.e(TAG, "Error requesting to hide fill UI", e); } + + mInlineSessionController.hideInlineSuggestionsUiLocked(id); } }