From 3792c8cb46593fb063df4f2c9380fe2ccf9066ee Mon Sep 17 00:00:00 2001 From: JW Wang Date: Thu, 10 Sep 2020 11:32:31 +0800 Subject: [PATCH] Remove #updateStoredSession (6/n) Per offline discussion, the mapping between id and session object won't change over time. There is no need to update the mapping again. Bug: 167996901 Test: atest StagedInstallTest StagedInstallInternalTest Change-Id: I24c0d648358d6ffab36a89598c297bdf4f62156e --- .../java/com/android/server/pm/StagingManager.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/services/core/java/com/android/server/pm/StagingManager.java b/services/core/java/com/android/server/pm/StagingManager.java index b12a8f89979bb..d4132136c2265 100644 --- a/services/core/java/com/android/server/pm/StagingManager.java +++ b/services/core/java/com/android/server/pm/StagingManager.java @@ -164,17 +164,6 @@ public class StagingManager { } } - private void updateStoredSession(@NonNull PackageInstallerSession sessionInfo) { - synchronized (mStagedSessions) { - PackageInstallerSession storedSession = mStagedSessions.get(sessionInfo.sessionId); - // storedSession might be null if a call to abortSession was made before the session - // is updated. - if (storedSession != null) { - mStagedSessions.put(sessionInfo.sessionId, sessionInfo); - } - } - } - private void markBootCompleted() { mApexManager.markBootCompleted(); } @@ -865,7 +854,6 @@ public class StagingManager { } void commitSession(@NonNull PackageInstallerSession session) { - updateStoredSession(session); mPreRebootVerificationHandler.startPreRebootVerification(session); }