From e19736f0520689747b9e703a40b5f574bd9a7fce Mon Sep 17 00:00:00 2001 From: John Wang Date: Tue, 7 Jun 2011 15:37:09 -0700 Subject: [PATCH] Make getDeviceId return null for Non-phone device. For non-phone device, i.e. tablet doesn't have voice capability, getDeviceId returns null while getPhoneType returns PHONE_TYPE_NONE. This behavior is suggested by developer scheme http://android-developers.blogspot.com/2011/03/identifying-app-installations.html and enforced by CTS testGetDeviceId. bug:4464907 Change-Id: Iaa3832b7323a50deccd438cb884c8e776a7a9640 --- telephony/java/android/telephony/TelephonyManager.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/telephony/java/android/telephony/TelephonyManager.java b/telephony/java/android/telephony/TelephonyManager.java index 8732e21998907..7aa9a2589d689 100644 --- a/telephony/java/android/telephony/TelephonyManager.java +++ b/telephony/java/android/telephony/TelephonyManager.java @@ -191,6 +191,10 @@ public class TelephonyManager { * {@link android.Manifest.permission#READ_PHONE_STATE READ_PHONE_STATE} */ public String getDeviceId() { + if (!isVoiceCapable()) { + return null; + } + try { return getSubscriberInfo().getDeviceId(); } catch (RemoteException ex) {