From dcf3d3711f6f5d87e6cd6b6673d301475c42df2f Mon Sep 17 00:00:00 2001 From: Patrick Baumann Date: Thu, 16 Jan 2020 15:22:22 -0800 Subject: [PATCH] Don't save self visibility grants This change avoids unnecessary grants of visibility between uids that are the same. Test: atest AppEnumerationTests AppsFilterTest Change-Id: I32447c3decee18e6149a8a1fdb56027fefbd3804 --- services/core/java/com/android/server/pm/AppsFilter.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/pm/AppsFilter.java b/services/core/java/com/android/server/pm/AppsFilter.java index 78e17192ed589..91f9d5cddfdfa 100644 --- a/services/core/java/com/android/server/pm/AppsFilter.java +++ b/services/core/java/com/android/server/pm/AppsFilter.java @@ -302,8 +302,9 @@ public class AppsFilter { * initiating uid. */ public void grantImplicitAccess(int callingUid, int targetUid) { - if (mImplicitlyQueryable.add(targetUid, callingUid) && DEBUG_LOGGING) { - Slog.wtf(TAG, "implicit access granted: " + callingUid + " -> " + targetUid); + if (targetUid != callingUid + && mImplicitlyQueryable.add(targetUid, callingUid) && DEBUG_LOGGING) { + Slog.wtf(TAG, "implicit access granted: " + targetUid + " -> " + callingUid); } }