From 226fcca4729eeb82a5c63cbda2e39d005797c4c4 Mon Sep 17 00:00:00 2001 From: John Reck Date: Tue, 5 Sep 2017 11:24:59 -0700 Subject: [PATCH] Allow translucent RenderNode->Bitmap captures Set translucent to true when doing createHardwareBitmapFromRenderNode. This ensures that the buffer is initialized to transparent which is a safer default for this path. Marginally less performant in some cases, but as this is a rare capture safety is preferred for and performance can be revisted if it turns out to be an issue. Bug: 65164016 Test: builds Change-Id: I6467c0ccf46e5e2a87c31cc4855ced8275236ca9 --- core/jni/android_view_ThreadedRenderer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/jni/android_view_ThreadedRenderer.cpp b/core/jni/android_view_ThreadedRenderer.cpp index 46b0a79d9f6fe..e757ddd8cddec 100644 --- a/core/jni/android_view_ThreadedRenderer.cpp +++ b/core/jni/android_view_ThreadedRenderer.cpp @@ -888,7 +888,7 @@ static jobject android_view_ThreadedRenderer_createHardwareBitmapFromRenderNode( // Render into the surface { ContextFactory factory; - RenderProxy proxy{false, renderNode, &factory}; + RenderProxy proxy{true, renderNode, &factory}; proxy.loadSystemProperties(); proxy.setSwapBehavior(SwapBehavior::kSwap_discardBuffer); proxy.initialize(surface);