From 223bec74fcb8b41ff99487db671ae5b1cf01732f Mon Sep 17 00:00:00 2001 From: Shan Huang Date: Wed, 25 May 2022 17:28:25 -0700 Subject: [PATCH] Remove TODOs for adding CTS tests. Bug: 232341407 Bug: 232845902 Test: atest KeyboardVisibilityControlTest#testHideImeAfterBackPressed_ScreenOffOn --no-bazel-mode Test: atest KeyboardVisibilityControlTest#testNonImeFocusablePopupWindow_onTopOfIme --no-bazel-mode Change-Id: I36ce1846b6f1cfdbb8a9679306966a205842b3ff --- core/java/android/inputmethodservice/InputMethodService.java | 1 - core/java/android/window/ImeOnBackInvokedDispatcher.java | 2 -- 2 files changed, 3 deletions(-) diff --git a/core/java/android/inputmethodservice/InputMethodService.java b/core/java/android/inputmethodservice/InputMethodService.java index 4869516123335..6bbc02843ed4c 100644 --- a/core/java/android/inputmethodservice/InputMethodService.java +++ b/core/java/android/inputmethodservice/InputMethodService.java @@ -2897,7 +2897,6 @@ public class InputMethodService extends AbstractInputMethodService { // Back callback is typically unregistered in {@link #hideWindow()}, but it's possible // for {@link #doFinishInput()} to be called without {@link #hideWindow()} so we also // unregister here. - // TODO(b/232341407): Add CTS to verify back behavior after screen on / off. unregisterCompatOnBackInvokedCallback(); } diff --git a/core/java/android/window/ImeOnBackInvokedDispatcher.java b/core/java/android/window/ImeOnBackInvokedDispatcher.java index 5924844aa3b26..055217ee9cf10 100644 --- a/core/java/android/window/ImeOnBackInvokedDispatcher.java +++ b/core/java/android/window/ImeOnBackInvokedDispatcher.java @@ -219,8 +219,6 @@ public class ImeOnBackInvokedDispatcher implements OnBackInvokedDispatcher, Parc * @param previous the previously focused {@link ViewRootImpl}. * @param current the currently focused {@link ViewRootImpl}. */ - // TODO(b/232845902): Add CTS to test IME back behavior when there's root view change while - // IME is up. public void switchRootView(ViewRootImpl previous, ViewRootImpl current) { for (ImeOnBackInvokedCallback imeCallback : mImeCallbacks) { if (previous != null) {