From 991146f8ef2ba3e5610191b82a6144013ce7e8c1 Mon Sep 17 00:00:00 2001 From: Craig Mautner Date: Thu, 13 Feb 2014 11:12:42 -0800 Subject: [PATCH] Don't null class member before using it. Changing the order of detachStack() and usage of mDisplayContent fixes NPE. Fixes bug 12823709. Change-Id: I04760b1d6fd5d3ffc49b99ca4acb47bf7e61cb46 --- services/core/java/com/android/server/wm/TaskStack.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/wm/TaskStack.java b/services/core/java/com/android/server/wm/TaskStack.java index 7d8cff4a8040c..6bd1a69cbfe71 100644 --- a/services/core/java/com/android/server/wm/TaskStack.java +++ b/services/core/java/com/android/server/wm/TaskStack.java @@ -371,11 +371,11 @@ public class TaskStack { (mDisplayContent.mDeferredActions & DisplayContent.DEFER_DETACH) != 0 && !isAnimating()) { mDisplayContent.mDeferredActions &= ~DisplayContent.DEFER_DETACH; - mService.detachStack(mStackId); if ((mDisplayContent.mDeferredActions & DisplayContent.DEFER_REMOVAL) != 0) { mDisplayContent.mDeferredActions &= ~DisplayContent.DEFER_REMOVAL; mService.onDisplayRemoved(mDisplayContent.getDisplayId()); } + mService.detachStack(mStackId); } for (int taskNdx = mTasks.size() - 1; taskNdx >= 0; --taskNdx) { final Task task = mTasks.get(taskNdx);