From c3081179d8961a291c47c05f52b63c134284cd4d Mon Sep 17 00:00:00 2001 From: Jorim Jaggi Date: Fri, 8 Apr 2016 23:56:37 -0700 Subject: [PATCH] Fix some jank in quick settings - Don't use layers for tiles - that leads to jank and it's not used. - Force the ripple for the expand button in software, so we don't get scheduling issues with RenderThread. Bug: 28095199 Change-Id: Ie46a0d54850d7eec1bd5412be8d4a8f0ff4b91d6 --- .../src/com/android/systemui/qs/QSTileBaseView.java | 6 ++++++ .../systemui/statusbar/phone/QuickStatusBarHeader.java | 1 + 2 files changed, 7 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/qs/QSTileBaseView.java b/packages/SystemUI/src/com/android/systemui/qs/QSTileBaseView.java index 9e40cfd91ebbb..44b38f1b6e6aa 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QSTileBaseView.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QSTileBaseView.java @@ -93,6 +93,12 @@ public class QSTileBaseView extends LinearLayout { } } + @Override + public boolean hasOverlappingRendering() { + // Avoid layers for this layout - we don't need them. + return false; + } + /** * Update the accessibility order for this view. * diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/QuickStatusBarHeader.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/QuickStatusBarHeader.java index ea9a5a587e539..2b03dfb841c3a 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/QuickStatusBarHeader.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/QuickStatusBarHeader.java @@ -125,6 +125,7 @@ public class QuickStatusBarHeader extends BaseStatusBarHeader implements // RenderThread is doing more harm than good when touching the header (to expand quick // settings), so disable it for this view ((RippleDrawable) mSettingsButton.getBackground()).setForceSoftware(true); + ((RippleDrawable) mExpandIndicator.getBackground()).setForceSoftware(true); updateResources(); }