From 8e9b6f3f4e4365fd5971cd5630030b51cd80216f Mon Sep 17 00:00:00 2001 From: Jeff DeCew Date: Thu, 10 Jun 2021 13:31:22 -0400 Subject: [PATCH] Fix NPE in logActionClick when we were re-fetching the NotificationEntry we already had. Fixes: 189234737 Test: click a bunch of actions Change-Id: I295eaadbef9f31b10e92f6d04d80cfe367a22af0 --- .../systemui/statusbar/NotificationRemoteInputManager.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java index ca81a7b43df66..0b67e7eeb1327 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java @@ -221,12 +221,10 @@ public class NotificationRemoteInputManager implements Dumpable { buttonIndex = actionGroup.indexOfChild(view); } final int count = mEntryManager.getActiveNotificationsCount(); - final int rank = mEntryManager - .getActiveNotificationUnfiltered(key).getRanking().getRank(); + final int rank = entry.getRanking().getRank(); NotificationVisibility.NotificationLocation location = - NotificationLogger.getNotificationLocation( - mEntryManager.getActiveNotificationUnfiltered(key)); + NotificationLogger.getNotificationLocation(entry); final NotificationVisibility nv = NotificationVisibility.obtain(key, rank, count, true, location); mClickNotifier.onNotificationActionClick(key, buttonIndex, action, nv, false);