diff --git a/packages/SettingsLib/MainSwitchPreference/res/layout-v31/settingslib_main_switch_bar.xml b/packages/SettingsLib/MainSwitchPreference/res/layout-v31/settingslib_main_switch_bar.xml index 30748e6244cbb..d2a4de4aa86fe 100644 --- a/packages/SettingsLib/MainSwitchPreference/res/layout-v31/settingslib_main_switch_bar.xml +++ b/packages/SettingsLib/MainSwitchPreference/res/layout-v31/settingslib_main_switch_bar.xml @@ -50,7 +50,7 @@ android:tint="?android:attr/colorAccent" android:layout_gravity="center_vertical" android:layout_marginEnd="@dimen/settingslib_restricted_icon_margin_end" - android:src="@android:drawable/ic_info" + android:src="@drawable/settingslib_ic_info" android:visibility="gone" /> - - diff --git a/packages/SettingsLib/res/layout/restricted_preference_widget_primary_switch.xml b/packages/SettingsLib/res/layout/restricted_preference_widget_primary_switch.xml deleted file mode 100644 index 69df7516a82a9..0000000000000 --- a/packages/SettingsLib/res/layout/restricted_preference_widget_primary_switch.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/packages/SettingsLib/res/layout/restricted_switch_widget.xml b/packages/SettingsLib/res/layout/restricted_switch_widget.xml deleted file mode 100644 index 1520ac88f5dbf..0000000000000 --- a/packages/SettingsLib/res/layout/restricted_switch_widget.xml +++ /dev/null @@ -1,32 +0,0 @@ - - - - - - - diff --git a/packages/SettingsLib/src/com/android/settingslib/PrimarySwitchPreference.java b/packages/SettingsLib/src/com/android/settingslib/PrimarySwitchPreference.java index 246fc8ddd4668..b43b44421fb82 100644 --- a/packages/SettingsLib/src/com/android/settingslib/PrimarySwitchPreference.java +++ b/packages/SettingsLib/src/com/android/settingslib/PrimarySwitchPreference.java @@ -59,7 +59,7 @@ public class PrimarySwitchPreference extends RestrictedPreference { @Override protected int getSecondTargetResId() { - return R.layout.restricted_preference_widget_primary_switch; + return R.layout.preference_widget_primary_switch; } @Override @@ -67,7 +67,6 @@ public class PrimarySwitchPreference extends RestrictedPreference { super.onBindViewHolder(holder); final View switchWidget = holder.findViewById(R.id.switchWidget); if (switchWidget != null) { - switchWidget.setVisibility(isDisabledByAdmin() ? View.GONE : View.VISIBLE); switchWidget.setOnClickListener(new OnClickListener() { @Override public void onClick(View v) { diff --git a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreference.java b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreference.java index 81146fa9ffd19..db2a6ec2da68f 100644 --- a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreference.java +++ b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreference.java @@ -22,7 +22,6 @@ import android.content.Context; import android.os.Process; import android.os.UserHandle; import android.util.AttributeSet; -import android.view.View; import androidx.core.content.res.TypedArrayUtils; import androidx.preference.PreferenceManager; @@ -66,24 +65,10 @@ public class RestrictedPreference extends TwoTargetPreference { android.R.attr.preferenceStyle), 0, packageName, uid); } - @Override - protected int getSecondTargetResId() { - return R.layout.restricted_icon; - } - - @Override - protected boolean shouldHideSecondTarget() { - return !isDisabledByAdmin(); - } - @Override public void onBindViewHolder(PreferenceViewHolder holder) { super.onBindViewHolder(holder); mHelper.onBindViewHolder(holder); - final View restrictedIcon = holder.findViewById(R.id.restricted_icon); - if (restrictedIcon != null) { - restrictedIcon.setVisibility(isDisabledByAdmin() ? View.VISIBLE : View.GONE); - } } @Override diff --git a/packages/SettingsLib/src/com/android/settingslib/RestrictedSwitchPreference.java b/packages/SettingsLib/src/com/android/settingslib/RestrictedSwitchPreference.java index 342189d8aa4c0..c607d742938a4 100644 --- a/packages/SettingsLib/src/com/android/settingslib/RestrictedSwitchPreference.java +++ b/packages/SettingsLib/src/com/android/settingslib/RestrictedSwitchPreference.java @@ -46,7 +46,6 @@ public class RestrictedSwitchPreference extends SwitchPreference { public RestrictedSwitchPreference(Context context, AttributeSet attrs, int defStyleAttr, int defStyleRes) { super(context, attrs, defStyleAttr, defStyleRes); - setWidgetLayoutResource(R.layout.restricted_switch_widget); mHelper = new RestrictedPreferenceHelper(context, this, attrs); if (attrs != null) { final TypedArray attributes = context.obtainStyledAttributes(attrs, @@ -108,15 +107,6 @@ public class RestrictedSwitchPreference extends SwitchPreference { switchSummary = mRestrictedSwitchSummary; } - final View restrictedIcon = holder.findViewById(R.id.restricted_icon); - final View switchWidget = holder.findViewById(android.R.id.switch_widget); - if (restrictedIcon != null) { - restrictedIcon.setVisibility(isDisabledByAdmin() ? View.VISIBLE : View.GONE); - } - if (switchWidget != null) { - switchWidget.setVisibility(isDisabledByAdmin() ? View.GONE : View.VISIBLE); - } - final ImageView icon = holder.itemView.findViewById(android.R.id.icon); if (mIconSize > 0) { diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/PrimarySwitchPreferenceTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/PrimarySwitchPreferenceTest.java index 4e2b63b6be578..9c16740061fe8 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/PrimarySwitchPreferenceTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/PrimarySwitchPreferenceTest.java @@ -53,13 +53,7 @@ public class PrimarySwitchPreferenceTest { mHolder = PreferenceViewHolder.createInstanceForTests(inflater.inflate( com.android.settingslib.R.layout.preference_two_target, null)); mWidgetView = mHolder.itemView.findViewById(android.R.id.widget_frame); - inflater.inflate(R.layout.restricted_preference_widget_primary_switch, mWidgetView, true); - } - - @Test - public void createNewPreference_shouldSetLayout() { - assertThat(mPreference.getWidgetLayoutResource()) - .isEqualTo(R.layout.restricted_preference_widget_primary_switch); + inflater.inflate(R.layout.preference_widget_primary_switch, mWidgetView, true); } @Test