From 7453178c200d77750126f74cce1141b5ffbdb6ff Mon Sep 17 00:00:00 2001 From: Zixuan Qu Date: Wed, 23 Nov 2022 21:04:38 +0000 Subject: [PATCH] Add @RequiresPermission annotation to virtual input device creation binder calls. This is to avoid the following build warning: [AndroidFrameworkRequiresPermission] Method createVirtualKeyboard() annotated [none] but too narrow; invokes method requiring {allOf=[android.permission.CREATE_VIRTUAL_DEVICE]} Bug: 237537306 Test: atest VirtualDeviceManagerServiceTest Change-Id: I36606da2d58bc4020618060a02193b6d69470c09 --- .../android/server/companion/virtual/VirtualDeviceImpl.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java index d83c80fcca6a4..0def25d322efb 100644 --- a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java +++ b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java @@ -411,6 +411,7 @@ final class VirtualDeviceImpl extends IVirtualDevice.Stub } } + @RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE) @Override // Binder call public void createVirtualKeyboard( int displayId, @@ -437,6 +438,7 @@ final class VirtualDeviceImpl extends IVirtualDevice.Stub } } + @RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE) @Override // Binder call public void createVirtualMouse( int displayId, @@ -462,6 +464,7 @@ final class VirtualDeviceImpl extends IVirtualDevice.Stub } } + @RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE) @Override // Binder call public void createVirtualTouchscreen( int displayId,