From 94d63e4f347ef0f6a7e9f923dfd495c236b285a1 Mon Sep 17 00:00:00 2001 From: mattsziklay Date: Wed, 26 Apr 2023 14:54:07 -0700 Subject: [PATCH] Correctly apply transaction on the end of veiled resize. Fixes a bug where a resize would not apply on the task surface on the end of drag. Bug: 274773589 Test: Manual, confirm drag end correctly resizes task. Test: atest WMShellUnitTests:VeiledResizeTaskPositionerTest Change-Id: Idf2ebc09f551f6a8de6419c8dc0f146311364deb --- .../wm/shell/windowdecor/VeiledResizeTaskPositioner.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/VeiledResizeTaskPositioner.java b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/VeiledResizeTaskPositioner.java index ef8332f5e3471..1d416c65851ba 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/VeiledResizeTaskPositioner.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/VeiledResizeTaskPositioner.java @@ -86,9 +86,10 @@ public class VeiledResizeTaskPositioner implements DragPositioningCallback { public void onDragPositioningEnd(float x, float y) { PointF delta = DragPositioningCallbackUtility.calculateDelta(x, y, mRepositionStartPoint); - if (mHasMoved && DragPositioningCallbackUtility.changeBounds(mCtrlType, mHasMoved, - mRepositionTaskBounds, mTaskBoundsAtDragStart, mStableBounds, delta, - mDisplayController, mDesktopWindowDecoration)) { + if (mHasMoved) { + DragPositioningCallbackUtility.changeBounds(mCtrlType, mHasMoved, + mRepositionTaskBounds, mTaskBoundsAtDragStart, mStableBounds, delta, + mDisplayController, mDesktopWindowDecoration); DragPositioningCallbackUtility.applyTaskBoundsChange( new WindowContainerTransaction(), mDesktopWindowDecoration, mRepositionTaskBounds, mTaskOrganizer);