From 463a52d59d4702ef30186e0120e47be32f0a04b3 Mon Sep 17 00:00:00 2001 From: "Chris.CC Lee" Date: Wed, 18 Sep 2019 02:55:47 +0000 Subject: [PATCH] Revert "Apply front scrim to doze pulsing" This reverts commit 84d6b0bfc3bbf765cd567a740ec5d88ab675bf25. Reason for revert: This change does not cover state switching between AOD and PULSING. Change-Id: I06b7375f57dd9035269563d9ae1476b8fc8f86f4 --- .../systemui/statusbar/phone/ScrimController.java | 4 ++-- .../statusbar/phone/ScrimControllerTest.java | 15 ++------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java index f853b638db464..8c95b844ae2f9 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java @@ -503,8 +503,8 @@ public class ScrimController implements ViewTreeObserver.OnPreDrawListener, OnCo * device is dozing when the light sensor is on. */ public void setAodFrontScrimAlpha(float alpha) { - if (((mState == ScrimState.AOD && mDozeParameters.getAlwaysOn()) - || mState == ScrimState.PULSING) && mInFrontAlpha != alpha) { + if (mState == ScrimState.AOD && mDozeParameters.getAlwaysOn() + && mInFrontAlpha != alpha) { mInFrontAlpha = alpha; updateScrims(); } diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java index 5d3cdc88aa99e..2623b46ba50fa 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java @@ -243,7 +243,7 @@ public class ScrimControllerTest extends SysuiTestCase { } @Test - public void transitionToPulsing_withFrontAlphaUpdates() { + public void transitionToPulsing() { // Pre-condition // Need to go to AoD first because PULSING doesn't change // the back scrim opacity - otherwise it would hide AoD wallpapers. @@ -267,22 +267,11 @@ public class ScrimControllerTest extends SysuiTestCase { true /* behind */, false /* bubble */); - // ... and when ambient goes dark, front scrim should be semi-transparent - mScrimController.setAodFrontScrimAlpha(0.5f); - mScrimController.finishAnimationsImmediately(); - // Front scrim should be semi-transparent - assertScrimAlpha(SEMI_TRANSPARENT /* front */, - OPAQUE /* back */, - TRANSPARENT /* bubble */); - mScrimController.setWakeLockScreenSensorActive(true); mScrimController.finishAnimationsImmediately(); - assertScrimAlpha(SEMI_TRANSPARENT /* front */, + assertScrimAlpha(TRANSPARENT /* front */, SEMI_TRANSPARENT /* back */, TRANSPARENT /* bubble */); - - // Reset value since enums are static. - mScrimController.setAodFrontScrimAlpha(0f); } @Test