From b0a738997b47b18b68f740673e828a32b8c17d5e Mon Sep 17 00:00:00 2001 From: Nataniel Borges Date: Mon, 31 Oct 2022 15:53:33 +0000 Subject: [PATCH] Fix open app cold in landscape And disable it from gestural nav because of a TAPl issue Fixes: 256616154 Bug: 240916028 Test: atest FlickerTests Change-Id: Id5df85c7ff766ea712c3b9d51f5f1df2a56a18cc --- .../server/wm/flicker/launch/OpenAppColdFromIcon.kt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppColdFromIcon.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppColdFromIcon.kt index 73e6d223f8248..5e6fc2129a6a1 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppColdFromIcon.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppColdFromIcon.kt @@ -19,11 +19,11 @@ package com.android.server.wm.flicker.launch import android.platform.test.annotations.FlakyTest import android.platform.test.annotations.RequiresDevice import android.view.Surface +import android.view.WindowManagerPolicyConstants import com.android.server.wm.flicker.FlickerParametersRunnerFactory import com.android.server.wm.flicker.FlickerTestParameter import com.android.server.wm.flicker.FlickerTestParameterFactory import com.android.server.wm.flicker.dsl.FlickerBuilder -import com.android.server.wm.flicker.helpers.setRotation import com.android.server.wm.flicker.rules.RemoveAllTasksButHomeRule import org.junit.FixMethodOrder import org.junit.Test @@ -68,7 +68,6 @@ class OpenAppColdFromIcon(testSpec: FlickerTestParameter) : tapl.setExpectedRotation(Surface.ROTATION_0) } RemoveAllTasksButHomeRule.removeAllTasksButHome() - this.setRotation(testSpec.startRotation) } transitions { tapl @@ -187,7 +186,13 @@ class OpenAppColdFromIcon(testSpec: FlickerTestParameter) : @Parameterized.Parameters(name = "{0}") @JvmStatic fun getParams(): Collection { - return FlickerTestParameterFactory.getInstance().getConfigNonRotationTests() + return FlickerTestParameterFactory.getInstance() + // TAPL fails on landscape mode b/240916028 + .getConfigNonRotationTests( + supportedNavigationModes = listOf( + WindowManagerPolicyConstants.NAV_BAR_MODE_3BUTTON_OVERLAY + ) + ) } } }