From 1c691f5bd2ac9b54c954d2009096bd774f5f4638 Mon Sep 17 00:00:00 2001 From: Varun Shah Date: Thu, 6 Aug 2020 22:09:32 +0000 Subject: [PATCH] Don't create unnecessary objects. Only create a new LinkedList if one doesn't exist already for the user. Bug: n/a Test: atest UsageStatsTest --- .../java/com/android/server/usage/UsageStatsService.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/services/usage/java/com/android/server/usage/UsageStatsService.java b/services/usage/java/com/android/server/usage/UsageStatsService.java index 2fd6c4249f99e..78556ef41edb0 100644 --- a/services/usage/java/com/android/server/usage/UsageStatsService.java +++ b/services/usage/java/com/android/server/usage/UsageStatsService.java @@ -763,11 +763,12 @@ public class UsageStatsService extends SystemService implements return; } - final LinkedList events = mReportedEvents.get(userId, new LinkedList<>()); - events.add(event); - if (mReportedEvents.get(userId) == null) { + LinkedList events = mReportedEvents.get(userId); + if (events == null) { + events = new LinkedList<>(); mReportedEvents.put(userId, events); } + events.add(event); if (events.size() == 1) { // Every time a file is persisted to disk, mReportedEvents is cleared for this user // so trigger a flush to disk every time the first event has been added.