From 6fc5438dfd43be66304432bb61d61a5e967ae86a Mon Sep 17 00:00:00 2001 From: Rambo Wang Date: Fri, 24 Apr 2020 16:37:16 -0700 Subject: [PATCH] Rename satisfiedBy to canBeSatisfiedBy for MatchAllNetworkSpecifier MatchAllNetworkSpecifier is a subclass of NetworkSpecifer. The method satisfiedBy should be renamed to canBeSatisfiedBy together with other subclass of NetworkSpecifer in b/152238712. Add annotation @Overide for the method to make sure it will not get ignored when refactor in the future. Bug: 154956584 Test: atest android.net.MatchAllNetworkSpecifierTest Change-Id: Ibe32fd50fae43aa635c1c0dad66eaea82011c8b7 --- core/java/android/net/MatchAllNetworkSpecifier.java | 3 ++- .../common/java/android/net/MatchAllNetworkSpecifierTest.kt | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/core/java/android/net/MatchAllNetworkSpecifier.java b/core/java/android/net/MatchAllNetworkSpecifier.java index 68a39355198ba..70c4a7235b9de 100644 --- a/core/java/android/net/MatchAllNetworkSpecifier.java +++ b/core/java/android/net/MatchAllNetworkSpecifier.java @@ -43,7 +43,8 @@ public final class MatchAllNetworkSpecifier extends NetworkSpecifier implements } /** @hide */ - public boolean satisfiedBy(NetworkSpecifier other) { + @Override + public boolean canBeSatisfiedBy(NetworkSpecifier other) { /* * The method is called by a NetworkRequest to see if it is satisfied by a proposed * network (e.g. as offered by a network factory). Since MatchAllNetweorkSpecifier must diff --git a/tests/net/common/java/android/net/MatchAllNetworkSpecifierTest.kt b/tests/net/common/java/android/net/MatchAllNetworkSpecifierTest.kt index ef15b668e24ca..a50f0461fae63 100644 --- a/tests/net/common/java/android/net/MatchAllNetworkSpecifierTest.kt +++ b/tests/net/common/java/android/net/MatchAllNetworkSpecifierTest.kt @@ -39,12 +39,12 @@ class MatchAllNetworkSpecifierTest { } @Test(expected = IllegalStateException::class) - fun testSatisfiedBy() { + fun testCanBeSatisfiedBy() { val specifier = MatchAllNetworkSpecifier() val discoverySession = Mockito.mock(DiscoverySession::class.java) val peerHandle = Mockito.mock(PeerHandle::class.java) val wifiAwareNetworkSpecifier = WifiAwareNetworkSpecifier.Builder(discoverySession, peerHandle).build() - specifier.satisfiedBy(wifiAwareNetworkSpecifier) + specifier.canBeSatisfiedBy(wifiAwareNetworkSpecifier) } }