Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am 01588aca: Merge "Preserve invariant that sService is not null (although NfcAdapter.get() can return null)" into gingerbread

Browse Source 
* commit '01588acaf87cfe9916239b7b26cc6810e0097138':
  Preserve invariant that sService is not null (although NfcAdapter.get() can return null)
This commit is contained in:
Nick Pelly
2011-07-13 22:38:44 -07:00
committed by Android Git Automerger
parent ab3ec17608 01588acaf8
commit 1bce9e25b6
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
nfc-extras/java/com/android/nfc_extras/NfcAdapterExtras.java
View File

@@ -67,7 +67,11 @@ public final class NfcAdapterExtras {
/** get service handles */ /** get service handles */
private static void initService() { private static void initService() {
sService = sAdapter.getNfcAdapterExtrasInterface(); final INfcAdapterExtras service = sAdapter.getNfcAdapterExtrasInterface();
if (service != null) {
// Leave stale rather than receive a null value.
sService = service;
}
} }
/** /**
@@ -84,18 +88,19 @@ public final class NfcAdapterExtras {
if (sSingleton == null) { if (sSingleton == null) {
try { try {
sAdapter = adapter; sAdapter = adapter;
sRouteOff = new CardEmulationRoute(CardEmulationRoute.ROUTE_OFF, null);
sSingleton = new NfcAdapterExtras(); sSingleton = new NfcAdapterExtras();
sEmbeddedEe = new NfcExecutionEnvironment(sSingleton); sEmbeddedEe = new NfcExecutionEnvironment(sSingleton);
sRouteOff = new CardEmulationRoute(CardEmulationRoute.ROUTE_OFF, null);
sRouteOnWhenScreenOn = new CardEmulationRoute( sRouteOnWhenScreenOn = new CardEmulationRoute(
CardEmulationRoute.ROUTE_ON_WHEN_SCREEN_ON, sEmbeddedEe); CardEmulationRoute.ROUTE_ON_WHEN_SCREEN_ON, sEmbeddedEe);
initService(); initService();
} finally { } finally {
if (sSingleton == null) { if (sService == null) {
sService = null;
sEmbeddedEe = null;
sRouteOff = null;
sRouteOnWhenScreenOn = null; sRouteOnWhenScreenOn = null;
sRouteOff = null;
sEmbeddedEe = null;
sSingleton = null;
sAdapter = null;
} }
} }
} }