From 1bca793f088fe3ea11369d5327b8fe758cf6a0c6 Mon Sep 17 00:00:00 2001 From: Rubin Xu Date: Thu, 7 Apr 2016 15:33:49 +0100 Subject: [PATCH] Remove temporary workaround of restoring periodic syncs. Bug: 28052438 Change-Id: Ic10070043c6431fd0a1a0346d8a6f1294dc27c41 --- .../android/server/content/SyncManager.java | 12 -------- .../server/content/SyncStorageEngine.java | 29 ------------------- 2 files changed, 41 deletions(-) diff --git a/services/core/java/com/android/server/content/SyncManager.java b/services/core/java/com/android/server/content/SyncManager.java index db41a54f1a0a2..8af0af093ed7b 100644 --- a/services/core/java/com/android/server/content/SyncManager.java +++ b/services/core/java/com/android/server/content/SyncManager.java @@ -1402,24 +1402,12 @@ public class SyncManager { } } - private void restoreLostPeriodicSyncsIfNeeded(int userId) { - List periodicSyncs = new ArrayList(); - for (SyncOperation sync : getAllPendingSyncs()) { - if (sync.isPeriodic && sync.target.userId == userId) { - periodicSyncs.add(sync); - } - } - mSyncStorageEngine.restorePeriodicSyncsIfNeededForUser(userId, periodicSyncs); - } - private void onUserUnlocked(int userId) { // Make sure that accounts we're about to use are valid. AccountManagerService.getSingleton().validateAccounts(userId); mSyncAdapters.invalidateCache(userId); - restoreLostPeriodicSyncsIfNeeded(userId); - EndPoint target = new EndPoint(null, null, userId); updateRunningAccounts(target); diff --git a/services/core/java/com/android/server/content/SyncStorageEngine.java b/services/core/java/com/android/server/content/SyncStorageEngine.java index fb23265c21898..bc3fc6a47aef7 100644 --- a/services/core/java/com/android/server/content/SyncStorageEngine.java +++ b/services/core/java/com/android/server/content/SyncStorageEngine.java @@ -826,35 +826,6 @@ public class SyncStorageEngine extends Handler { return true; } - /** - * STOPSHIP This is a temporary workaround and should be removed before shipping: b/28052438 - */ - void restorePeriodicSyncsIfNeededForUser(int userHandle, List periodicSyncs) { - if (mPeriodicSyncAddedListener == null) { - return; - } - synchronized (mAuthorities) { - for (int i = 0; i < mAuthorities.size(); i++) { - AuthorityInfo authority = mAuthorities.valueAt(i); - if (authority.target.userId == userHandle && authority.enabled) { - boolean periodicSyncAlreadyExists = false; - for (SyncOperation sync : periodicSyncs) { - if (authority.target.matchesSpec(sync.target)) { - periodicSyncAlreadyExists = true; - break; - } - } - // The periodic sync must have been lost due to previous bug. - if (!periodicSyncAlreadyExists) { - mPeriodicSyncAddedListener.onPeriodicSyncAdded(authority.target, - new Bundle(), DEFAULT_POLL_FREQUENCY_SECONDS, - calculateDefaultFlexTime(DEFAULT_POLL_FREQUENCY_SECONDS)); - } - } - } - } - } - public void setMasterSyncAutomatically(boolean flag, int userId) { synchronized (mAuthorities) { Boolean auto = mMasterSyncAutomatically.get(userId);