From fe43f4d52d05f330d52b0c5ec5ead58fad2628ed Mon Sep 17 00:00:00 2001 From: Aaron Huang Date: Mon, 24 Jan 2022 17:47:14 +0800 Subject: [PATCH] Remplace NetworkIdentity.OEM_* with NetworkTemplate.OEM_MANAGED_* Remove hidden APIs and replace the constants with SystemApi that are exposed by NetworkTemplate. Also fix typo and remove getElapsedRealtime() which is a hidden API from StatsPullAtomService. Bug: 210073043 Test: TH Change-Id: I8b980417faf776b9b7b0fbcc4f04525b516452a0 --- .../server/stats/pull/StatsPullAtomService.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/services/core/java/com/android/server/stats/pull/StatsPullAtomService.java b/services/core/java/com/android/server/stats/pull/StatsPullAtomService.java index e1800327d0f95..277d80235e3d8 100644 --- a/services/core/java/com/android/server/stats/pull/StatsPullAtomService.java +++ b/services/core/java/com/android/server/stats/pull/StatsPullAtomService.java @@ -23,13 +23,13 @@ import static android.content.pm.PermissionInfo.PROTECTION_DANGEROUS; import static android.net.NetworkCapabilities.TRANSPORT_CELLULAR; import static android.net.NetworkCapabilities.TRANSPORT_ETHERNET; import static android.net.NetworkCapabilities.TRANSPORT_WIFI; -import static android.net.NetworkIdentity.OEM_PAID; -import static android.net.NetworkIdentity.OEM_PRIVATE; import static android.net.NetworkStats.METERED_YES; import static android.net.NetworkTemplate.MATCH_ETHERNET; import static android.net.NetworkTemplate.MATCH_MOBILE; import static android.net.NetworkTemplate.MATCH_WIFI; import static android.net.NetworkTemplate.OEM_MANAGED_ALL; +import static android.net.NetworkTemplate.OEM_MANAGED_PAID; +import static android.net.NetworkTemplate.OEM_MANAGED_PRIVATE; import static android.net.NetworkTemplate.getAllCollapsedRatTypes; import static android.os.Debug.getIonHeapsSizeKb; import static android.os.Process.LAST_SHARED_APPLICATION_GID; @@ -1292,7 +1292,8 @@ public class StatsPullAtomService extends SystemService { new Pair(MATCH_MOBILE, TRANSPORT_CELLULAR), new Pair(MATCH_WIFI, TRANSPORT_WIFI) ); - final int[] oemManagedTypes = new int[] {OEM_PAID | OEM_PRIVATE, OEM_PAID, OEM_PRIVATE}; + final int[] oemManagedTypes = new int[] {OEM_MANAGED_PAID | OEM_MANAGED_PRIVATE, + OEM_MANAGED_PAID, OEM_MANAGED_PRIVATE}; final List ret = new ArrayList<>(); @@ -1368,12 +1369,12 @@ public class StatsPullAtomService extends SystemService { NetworkStatsUtils.fromPublicNetworkStats(queryNonTaggedStats); if (!includeTags) return nonTaggedStats; - final android.app.usage.NetworkStats quaryTaggedStats = + final android.app.usage.NetworkStats queryTaggedStats = mNetworkStatsManager.queryTaggedSummary(template, currentTimeInMillis - elapsedMillisSinceBoot - bucketDuration, currentTimeInMillis); final NetworkStats taggedStats = - NetworkStatsUtils.fromPublicNetworkStats(quaryTaggedStats); + NetworkStatsUtils.fromPublicNetworkStats(queryTaggedStats); return nonTaggedStats.add(taggedStats); } @@ -1470,7 +1471,7 @@ public class StatsPullAtomService extends SystemService { */ @NonNull private NetworkStats sliceNetworkStats(@NonNull NetworkStats stats, @NonNull Function slicer) { - NetworkStats ret = new NetworkStats(stats.getElapsedRealtime(), 1); + NetworkStats ret = new NetworkStats(0, 1); NetworkStats.Entry entry = new NetworkStats.Entry(); for (NetworkStats.Entry e : stats) { if (slicer != null) {