From dc32a99889045824482f69a3d175d6d5305e392c Mon Sep 17 00:00:00 2001 From: Gilles Debunne Date: Mon, 10 Jan 2011 18:45:44 -0800 Subject: [PATCH] Blinking runnable is created only if text is editable. DO NOT MERGE. Change-Id: If85acc73cfa12b6da23d60459a746e1aef51d3aa --- core/java/android/widget/TextView.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index 41c973614b821..fba27af8bc905 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -6523,7 +6523,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener } private void makeBlink() { - if (!mCursorVisible) { + if (!mCursorVisible || !isTextEditable()) { if (mBlink != null) { mBlink.removeCallbacks(mBlink); } @@ -6912,7 +6912,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener * @return True iff this TextView contains a text that can be edited. */ private boolean isTextEditable() { - return mText instanceof Editable && onCheckIsTextEditor(); + return mText instanceof Editable && onCheckIsTextEditor() && isEnabled(); } /**