From 1b968ed8a9f33f8734ad579a477729231db71ad5 Mon Sep 17 00:00:00 2001 From: Fabian Kozynski Date: Tue, 3 Mar 2020 18:50:45 -0500 Subject: [PATCH] Fix ControlsProviderLifecycleManagerTest Flushes executor in each test to get through the correct flow. Fixes: 150719701 Test: atest ControlsProviderLifecycleManagerTest Change-Id: I0e76fbbad05038ab1055088ad53c81c9cb7bbddc --- .../ControlsProviderLifecycleManagerTest.kt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/packages/SystemUI/tests/src/com/android/systemui/controls/controller/ControlsProviderLifecycleManagerTest.kt b/packages/SystemUI/tests/src/com/android/systemui/controls/controller/ControlsProviderLifecycleManagerTest.kt index a3e59e52abe51..fd92ad0263127 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/controls/controller/ControlsProviderLifecycleManagerTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/controls/controller/ControlsProviderLifecycleManagerTest.kt @@ -97,19 +97,25 @@ class ControlsProviderLifecycleManagerTest : SysuiTestCase() { @Test fun testBindService() { manager.bindService() + executor.runAllReady() assertTrue(mContext.isBound(componentName)) } @Test fun testUnbindService() { manager.bindService() + executor.runAllReady() + manager.unbindService() + executor.runAllReady() + assertFalse(mContext.isBound(componentName)) } @Test fun testMaybeBindAndLoad() { manager.maybeBindAndLoad(subscriberService) + executor.runAllReady() verify(service).load(subscriberService) @@ -119,14 +125,17 @@ class ControlsProviderLifecycleManagerTest : SysuiTestCase() { @Test fun testMaybeUnbind_bindingAndCallback() { manager.maybeBindAndLoad(subscriberService) + executor.runAllReady() manager.unbindService() + executor.runAllReady() assertFalse(mContext.isBound(componentName)) } @Test fun testMaybeBindAndLoad_timeout() { manager.maybeBindAndLoad(subscriberService) + executor.runAllReady() executor.advanceClockToLast() executor.runAllReady() @@ -138,6 +147,7 @@ class ControlsProviderLifecycleManagerTest : SysuiTestCase() { fun testMaybeBindAndSubscribe() { val list = listOf("TEST_ID") manager.maybeBindAndSubscribe(list) + executor.runAllReady() assertTrue(mContext.isBound(componentName)) verify(service).subscribe(list, subscriberService) @@ -148,6 +158,7 @@ class ControlsProviderLifecycleManagerTest : SysuiTestCase() { val controlId = "TEST_ID" val action = ControlAction.ERROR_ACTION manager.maybeBindAndSendAction(controlId, action) + executor.runAllReady() assertTrue(mContext.isBound(componentName)) verify(service).action(eq(controlId), capture(wrapperCaptor),