From 1b37c3bddcdfe7cb60e776e3eb05bfbb46b0b282 Mon Sep 17 00:00:00 2001 From: Mattias Nilsson Date: Wed, 26 Mar 2014 13:38:34 +0100 Subject: [PATCH] Release DrmManagerClient resources Call release for DrmManagerClient to avoid resource leaks Introduced by following commit (5d143ad4a8f...), "Media scanner support for FL(Forward Lock) DRM file types" Change-Id: Ic3c458579f4e99b3b072a2e13362d1996b982589 --- media/java/android/media/MediaScanner.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/media/java/android/media/MediaScanner.java b/media/java/android/media/MediaScanner.java index 53835e2dbeb29..75025576ddfdd 100644 --- a/media/java/android/media/MediaScanner.java +++ b/media/java/android/media/MediaScanner.java @@ -1280,6 +1280,14 @@ public class MediaScanner mMediaProvider = null; } + private void releaseResources() { + // release the DrmManagerClient resources + if (mDrmManagerClient != null) { + mDrmManagerClient.release(); + mDrmManagerClient = null; + } + } + private void initialize(String volumeName) { mMediaProvider = mContext.getContentResolver().acquireProvider("media"); @@ -1340,6 +1348,8 @@ public class MediaScanner Log.e(TAG, "UnsupportedOperationException in MediaScanner.scan()", e); } catch (RemoteException e) { Log.e(TAG, "RemoteException in MediaScanner.scan()", e); + } finally { + releaseResources(); } } @@ -1363,6 +1373,8 @@ public class MediaScanner } catch (RemoteException e) { Log.e(TAG, "RemoteException in MediaScanner.scanFile()", e); return null; + } finally { + releaseResources(); } } @@ -1477,6 +1489,7 @@ public class MediaScanner if (fileList != null) { fileList.close(); } + releaseResources(); } }