From 0f771dcecc2b47d5bb4d878749e43b16b314b204 Mon Sep 17 00:00:00 2001 From: Seth Moore Date: Tue, 4 Apr 2023 14:01:42 -0700 Subject: [PATCH] Don't log stacks for exceptions recieved from binder The stacks for these exceptions are not helpful, as they just show binder internals and spew noise into the logs. Test: Manual Change-Id: Ib3aae63b1f31a0ebbcbeaf7519bcd65b6903ab2c --- .../server/security/rkp/RemoteProvisioningRegistration.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/security/rkp/RemoteProvisioningRegistration.java b/services/core/java/com/android/server/security/rkp/RemoteProvisioningRegistration.java index 2d3ede02a6a4f..f586126196dda 100644 --- a/services/core/java/com/android/server/security/rkp/RemoteProvisioningRegistration.java +++ b/services/core/java/com/android/server/security/rkp/RemoteProvisioningRegistration.java @@ -70,12 +70,14 @@ final class RemoteProvisioningRegistration extends IRegistration.Stub { Log.i(TAG, "Operation cancelled for client " + mCallback.hashCode()); wrapCallback(mCallback::onCancel); } else if (e instanceof RkpProxyException) { - Log.e(TAG, "RKP error fetching key for client " + mCallback.hashCode(), e); + Log.e(TAG, "RKP error fetching key for client " + mCallback.hashCode() + ": " + + e.getMessage()); RkpProxyException rkpException = (RkpProxyException) e; wrapCallback(() -> mCallback.onError(toGetKeyError(rkpException), e.getMessage())); } else { - Log.e(TAG, "Error fetching key for client " + mCallback.hashCode(), e); + Log.e(TAG, "Unknown error fetching key for client " + mCallback.hashCode() + ": " + + e.getMessage()); wrapCallback(() -> mCallback.onError(IGetKeyCallback.ErrorCode.ERROR_UNKNOWN, e.getMessage())); }