From a84c6014ae333060eb83604e73eb399658bfc9bc Mon Sep 17 00:00:00 2001 From: Chalard Jean Date: Fri, 29 Oct 2021 14:48:31 +0900 Subject: [PATCH] Use static utils from f/l/n instead of the networkstack Test: NetworkManagementServiceTest Change-Id: I0383f542369f79986137084e76bce923d0df02a5 --- .../android/server/NetworkManagementService.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java index 3ea0ce1737459..c7e9068765262 100644 --- a/services/core/java/com/android/server/NetworkManagementService.java +++ b/services/core/java/com/android/server/NetworkManagementService.java @@ -59,9 +59,6 @@ import android.net.NetworkStats; import android.net.RouteInfo; import android.net.TetherStatsParcel; import android.net.UidRangeParcel; -import android.net.shared.NetdUtils; -import android.net.shared.RouteUtils; -import android.net.shared.RouteUtils.ModifyOperation; import android.net.util.NetdService; import android.os.BatteryStats; import android.os.Binder; @@ -88,6 +85,8 @@ import com.android.internal.app.IBatteryStats; import com.android.internal.util.DumpUtils; import com.android.internal.util.HexDump; import com.android.internal.util.Preconditions; +import com.android.net.module.util.NetdUtils; +import com.android.net.module.util.NetdUtils.ModifyOperation; import com.google.android.collect.Maps; @@ -831,13 +830,13 @@ public class NetworkManagementService extends INetworkManagementService.Stub { @Override public void addRoute(int netId, RouteInfo route) { NetworkStack.checkNetworkStackPermission(mContext); - RouteUtils.modifyRoute(mNetdService, ModifyOperation.ADD, netId, route); + NetdUtils.modifyRoute(mNetdService, ModifyOperation.ADD, netId, route); } @Override public void removeRoute(int netId, RouteInfo route) { NetworkStack.checkNetworkStackPermission(mContext); - RouteUtils.modifyRoute(mNetdService, ModifyOperation.REMOVE, netId, route); + NetdUtils.modifyRoute(mNetdService, ModifyOperation.REMOVE, netId, route); } private ArrayList readRouteList(String filename) { @@ -1785,7 +1784,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub { public void addInterfaceToLocalNetwork(String iface, List routes) { modifyInterfaceInNetwork(MODIFY_OPERATION_ADD, INetd.LOCAL_NET_ID, iface); // modifyInterfaceInNetwork already check calling permission. - RouteUtils.addRoutesToLocalNetwork(mNetdService, iface, routes); + NetdUtils.addRoutesToLocalNetwork(mNetdService, iface, routes); } @Override @@ -1796,7 +1795,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub { @Override public int removeRoutesFromLocalNetwork(List routes) { NetworkStack.checkNetworkStackPermission(mContext); - return RouteUtils.removeRoutesFromLocalNetwork(mNetdService, routes); + return NetdUtils.removeRoutesFromLocalNetwork(mNetdService, routes); } @Override