From d284612d8f12be8f6ab8fb275e71bbfa6c422b9a Mon Sep 17 00:00:00 2001 From: Fyodor Kupolov Date: Thu, 11 Feb 2016 18:06:34 -0800 Subject: [PATCH] Remove isPackageInstalled It's not required to check whether package is installed before sending a broadcast. Change-Id: I132e49087faad28b637f98cf79d7ec56dcb26ecd --- .../android/server/pm/UserManagerService.java | 24 +++++-------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java index 3cc7b10c6f242..2f0e8c047afd7 100644 --- a/services/core/java/com/android/server/pm/UserManagerService.java +++ b/services/core/java/com/android/server/pm/UserManagerService.java @@ -1749,16 +1749,6 @@ public class UserManagerService extends IUserManager.Stub { } } - private boolean isPackageInstalled(String pkg, int userId) { - final ApplicationInfo info = mPm.getApplicationInfo(pkg, - PackageManager.GET_UNINSTALLED_PACKAGES, - userId); - if (info == null || (info.flags&ApplicationInfo.FLAG_INSTALLED) == 0) { - return false; - } - return true; - } - /** * Removes the app restrictions file for a specific package and user id, if it exists. */ @@ -2201,20 +2191,18 @@ public class UserManagerService extends IUserManager.Stub { } } - if (isPackageInstalled(packageName, userId)) { - // Notify package of changes via an intent - only sent to explicitly registered receivers. - Intent changeIntent = new Intent(Intent.ACTION_APPLICATION_RESTRICTIONS_CHANGED); - changeIntent.setPackage(packageName); - changeIntent.addFlags(Intent.FLAG_RECEIVER_REGISTERED_ONLY); - mContext.sendBroadcastAsUser(changeIntent, new UserHandle(userId)); - } + // Notify package of changes via an intent - only sent to explicitly registered receivers. + Intent changeIntent = new Intent(Intent.ACTION_APPLICATION_RESTRICTIONS_CHANGED); + changeIntent.setPackage(packageName); + changeIntent.addFlags(Intent.FLAG_RECEIVER_REGISTERED_ONLY); + mContext.sendBroadcastAsUser(changeIntent, UserHandle.of(userId)); } private int getUidForPackage(String packageName) { long ident = Binder.clearCallingIdentity(); try { return mContext.getPackageManager().getApplicationInfo(packageName, - PackageManager.GET_UNINSTALLED_PACKAGES).uid; + PackageManager.MATCH_UNINSTALLED_PACKAGES).uid; } catch (NameNotFoundException nnfe) { return -1; } finally {