From 49dfa2825939eef3149c9e619177248ef094732b Mon Sep 17 00:00:00 2001 From: Sooraj Sasindran Date: Thu, 7 Apr 2022 12:07:13 -0700 Subject: [PATCH] Make sure mms proxy is hostname Bug: 226279832 Test: verified no regression in mms Change-Id: If08e70e4fb9b72065194552aa96c9dabe1c17f1e --- telephony/java/android/telephony/data/ApnSetting.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/telephony/java/android/telephony/data/ApnSetting.java b/telephony/java/android/telephony/data/ApnSetting.java index 8143da5ad4315..e97342b1bb568 100644 --- a/telephony/java/android/telephony/data/ApnSetting.java +++ b/telephony/java/android/telephony/data/ApnSetting.java @@ -24,6 +24,7 @@ import android.content.ContentValues; import android.database.Cursor; import android.hardware.radio.V1_5.ApnTypes; import android.net.Uri; +import android.os.Build; import android.os.Parcel; import android.os.Parcelable; import android.provider.Telephony; @@ -2183,6 +2184,14 @@ public class ApnSetting implements Parcelable { || TextUtils.isEmpty(mApnName) || TextUtils.isEmpty(mEntryName)) { return null; } + if ((mApnTypeBitmask & TYPE_MMS) != 0 && !TextUtils.isEmpty(mMmsProxyAddress) + && mMmsProxyAddress.startsWith("http")) { + if (Build.IS_DEBUGGABLE) { + throw new IllegalArgumentException("mms proxy(" + mMmsProxyAddress + + ") should be a hostname, not a url"); + } + return null; + } return new ApnSetting(this); }