From 1a028bcbd6ec52abe48806bac343a49c84ea667b Mon Sep 17 00:00:00 2001
From: "Philip P. Moltmann" <moltmann@google.com>
Date: Fri, 20 Jul 2018 09:05:20 -0700
Subject: [PATCH] More fine tuning of dialog width

Test: Looked at dialog in portait, splitscreen, and landscape mode
Change-Id: I54f40cdb1f76ade988cd011966c4f4035bfe7eb7
---
 core/res/res/values-land/dimens_package_installer.xml | 6 ++++--
 core/res/res/values-port/dimens_package_installer.xml | 5 +++--
 core/res/res/values/styles_package_installer.xml      | 4 ++--
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/core/res/res/values-land/dimens_package_installer.xml b/core/res/res/values-land/dimens_package_installer.xml
index 72f4ec22c36f7..2146241fd8307 100644
--- a/core/res/res/values-land/dimens_package_installer.xml
+++ b/core/res/res/values-land/dimens_package_installer.xml
@@ -17,6 +17,8 @@
 
 <!-- Landscape dimensions for the permission grant dialog. -->
 <resources>
-    <!-- 37:20 == 65% width -->
-    <dimen name="permissionGrantDialogWidth">37</dimen>
+    <!-- Assuming the dimension of a sailfish, this yields 95% width in splitscreen and 65% in
+         landscape -->
+    <dimen name="permissionGrantDialogWeight">8.6</dimen>
+    <dimen name="permissionGrantDialogWidth">334dp</dimen>
 </resources>
diff --git a/core/res/res/values-port/dimens_package_installer.xml b/core/res/res/values-port/dimens_package_installer.xml
index 67cafe7524094..af28713e5ba21 100644
--- a/core/res/res/values-port/dimens_package_installer.xml
+++ b/core/res/res/values-port/dimens_package_installer.xml
@@ -17,6 +17,7 @@
 
 <!-- portrait dimensions for the permission grant dialog. -->
 <resources>
-    <!-- 380:20 == 95% width -->
-    <dimen name="permissionGrantDialogWidth">380</dimen>
+    <!-- This yields 95% width -->
+    <dimen name="permissionGrantDialogWeight">380</dimen>
+    <dimen name="permissionGrantDialogWidth">0dp</dimen>
 </resources>
diff --git a/core/res/res/values/styles_package_installer.xml b/core/res/res/values/styles_package_installer.xml
index 2ccdd87524435..339f9c71a57ec 100644
--- a/core/res/res/values/styles_package_installer.xml
+++ b/core/res/res/values/styles_package_installer.xml
@@ -20,8 +20,8 @@
     <style name="PermissionGrantDialog">
         <item name="background">?attr/windowBackground</item>
         <item name="elevation">?attr/windowElevation</item>
-        <item name="layout_weight">@dimen/permissionGrantDialogWidth</item>
-        <item name="layout_width">320dp</item>
+        <item name="layout_weight">@dimen/permissionGrantDialogWeight</item>
+        <item name="layout_width">@dimen/permissionGrantDialogWidth</item>
     </style>
 
     <style name="PermissionGrantTitleIcon">